[Pkg-javascript-devel] Bug#872433: Bug#872433: [with solution] Doesn't find modules installed in Debian directories

[Julien Puydt]

Hi,

Le 17/08/2017 à 14:04, Bastien ROUCARIES a écrit :
> Could you also modernize this package ? policy bump, autopkg-test (see
> node-tape)

I bumped std-ver and dh compat if that's what you mean by policy bump.
There was already an autopkg-test directory and I added a test for my
patch (which has a DEP3 header).

Here is what my git-log has to say on the changes since debian/1.1.7-2
was released ; lintian only complains about unreleased-changes,
changelog-should-mention-nmu and source-nmu-has-incorrect-version-number
because I created a 1.4.0-1 and I'm not an uploader :

commit 706643f1cc5c6a6d72b0fa092379ed6f029b6540 (HEAD -> master)
Author: Julien Puydt <julien.puydt at laposte.net>
Date:   Thu Aug 17 13:54:36 2017 +0200

    Remove useless build-dep on dh-buildinfo

commit c5cf00738e9a7c597a86406ddb9ae1c7a8e086a3
Author: Julien Puydt <julien.puydt at laposte.net>
Date:   Thu Aug 17 13:52:23 2017 +0200

    Add an autopkgtest for the patch to enable Debian paths

commit 5303fa0df9bc3d0f223963a5af33da5f511cf245
Author: Julien Puydt <julien.puydt at laposte.net>
Date:   Thu Aug 17 13:46:31 2017 +0200

    Add a patch so node_modules isn't always added to searched paths

commit 92349b284cad11524a4a6f7acb1b979794a1d818
Author: Julien Puydt <julien.puydt at laposte.net>
Date:   Thu Aug 17 13:42:52 2017 +0200

    Bump std-ver to 4.0.0

commit 9bce40b53ef272e9c1035bbd1ad6c8299b55b654
Author: Julien Puydt <julien.puydt at laposte.net>
Date:   Thu Aug 17 13:41:45 2017 +0200

    Bump dh compat to 10

commit 16f46e9d3789232de1c2d41471851fbb20490014
Author: Julien Puydt <julien.puydt at laposte.net>
Date:   Wed Aug 16 19:36:15 2017 +0200

    Package upstream 1.4.0

commit 2ad252931b6710dab0a6d708c11e4cbe30ead326
Merge: febbf48 68dce8d
Author: Julien Puydt <julien.puydt at laposte.net>
Date:   Wed Aug 16 19:35:45 2017 +0200

    Updated version 1.4.0 from 'upstream/1.4.0'

    with Debian dir 641fcf33ab138af6a27661a439a7b435ac210f03

commit 68dce8d4a97fd679c5214be9dc2e16658a7b7cf3 (tag: upstream/1.4.0,
upstream)
Author: Julien Puydt <julien.puydt at laposte.net>
Date:   Wed Aug 16 19:35:39 2017 +0200

    New upstream version 1.4.0

commit febbf4801383e0b650432dda8eceeeb1f6275248 (origin/master, origin/HEAD)
Author: Mike Gabriel <mike.gabriel at das-netzwerkteam.de>
Date:   Thu Dec 15 11:21:37 2016 +0100

    debian/control: Drop myself from Uploaders: field.

commit b2e880ef277e4f2ebf7d20386066efc6ffc029fe (tag: debian/1.1.7-2)
Author: Thorsten Alteholz <debian at alteholz.de>
Date:   Fri Jun 17 19:56:34 2016 +0200

    fix typo



And here is what my d/ch entry looks like:
node-resolve (1.4.0-1) UNRELEASED; urgency=medium

  * New upstream release.
  * Bump dh compat to 10.
  * Bump std-ver to 4.0.0.
  * Add a patch so node_modules isn't always added to search paths.
  * Add an autopkgtest to check the patch mentioned above works.
  * Remove build-dep on dh-buildinfo.

 -- Julien Puydt <julien.puydt at laposte.net>  Wed, 16 Aug 2017 19:35:50 +0200

I think it doesn't look bad, but I'd rather have the uploader (Thorsten
Alteholz) tell me he's ok with me pushing those changes (or part of
them) and doing the upload.

Cheers,

Snark on #debian-js