[Pkg-javascript-devel] Bug#884154: Bug#884154: FTBFS with chai 4.1.2 in experimental

[Ghislain Vaillant]

Le 16/12/17 à 17:31, Pirate Praveen a écrit :
> On ശനി 16 ഡിസംബര്‍ 2017 10:44 വൈകു, Ghislain Vaillant wrote:
>> I don't know anything about chai. Besides, since you are its maintainer,
>> I would expect the investigation to be done by yourself rather than myself.
> 
> No, that is not how a transition is supposed to work. Do you expect
> maintainer of nodejs package to fix all issues of all packages using
> nodejs by themselves when updating nodejs versions?

You are deliberately taking an extreme case to fulfill your narrative. I 
would not fit nodejs and chai in the same basket.

> I did not even get heads up with webmock transition in ruby team. It was
> right away FTBFS and autoremoval from testing for packages failing to
> build with webmock 3.

And?

> I can try and help, but as maintainer of libjs-fetch, it is your
> responsibility to fix issues of your package when dependencies change.

We are talking about a *test* dependencies which now makes the build 
fail after a major version bump. It makes sense to expect more 
information from the corresponding maintainer.

Should we expect every single maintainer affected by an FTBFS to go read 
the release notes of chai in order to figure what broke between version 
3 and 4. I am very skeptical about this.

>> I meant context about why the package now FTBFS. I understand this is a
>> transition and I don't think uploading to unstable is wise before FTBFS
>> issues such as this one are fixed. Is there an urgency in having chai
>> 4.x in testing/unstable?
> 
> Indeed, that is why it is uploaded first to experimental and giving
> heads up to packages affected by this transition. We can definitely wait
> for a reasonable time before uploading to unstable.

Which is appreciated.

> 1. chai itself is FTBFS with nodejs 6

That's unfortunate indeed.

> 2. we generally want to ship the latest versions

But not systematically.

> 3. Some packages are already starting to require newer versions of chai,
> for example node-yargs (whose tests are disabled currently).

It makes sense to disable them if they specifically require chai >= 4.

> You could ask upstream to move to chai 4 and take their help. Or you
> could also disable tests.

Disabling the tests would be a serious downgrade considering testing is 
currently working, unlike node-yargs. I am seriously uncomfortable with 
this proposal.

I can ask upstream, though chai is officially pinned at version 2.x there.