[Pkg-javascript-devel] Bug#851318: Bug#851318: uglifyjs: FTBFS on slow machines (failing tests)

[Jonas Smedegaard]

Quoting Santiago Vila (2017-01-13 23:34:23)
> I tried to build this package in stretch with "dpkg-buildpackage -A"
> but it failed:
[...]
>   66 passing (34s)
>   1 failing
> 
>   1) bin/uglifyjs should produce a functional build when using --self:
>      Error: timeout of 5000ms exceeded
>       at null.<anonymous> (/usr/lib/nodejs/mocha/lib/runnable.js:139:19)
>       at Timer.listOnTimeout (timers.js:92:15)
> 
> 
> 
> debian/rules:52: recipe for target 'debian/stamp-build' failed
> make: *** [debian/stamp-build] Error 1
> dpkg-buildpackage: error: debian/rules build-indep gave error exit status 2
> --------------------------------------------------------------------------------
> 
> This is just how the build ends, not necessarily the relevant part.
> 
> I've put several build logs here:
> 
> https://people.debian.org/~sanvila/build-logs/uglifyjs/
> 
> If this is really a bug in one of the build-depends, please use 
> reassign and affects, so that this is still visible in the page for 
> this package.
> 
> I can reproduce this in a lot of different computers, all being 
> "slow", but there is not a policy anywhere saying that autobuilders 
> must be fast, so I'm not treating this one as a FTBFS-randomly bug.

I agree these failures are not random: Tests should not assume fast 
environment. 

Seems the proper fix is to patch test/mocha/cli.js to not have a timeout 
(or as workaround an insanely large timeout).

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-javascript-devel/attachments/20170208/512a0b61/attachment.sig>