[Pkg-javascript-devel] Bug#881735: nodejs: Please use whitelist for supported architectures

[John Paul Adrian Glaubitz]

Source: nodejs
Version: 6.12.0~dfsg-1
Severity: important

Hi!

src:nodejs currently fails to build from source on multiple architectures
because the buildds try to build the package despite not being supported
by NodeJS upstream in the first place [1]:

dpkg-buildpackage: info: source package nodejs
dpkg-buildpackage: info: source version 6.12.0~dfsg-1
dpkg-buildpackage: info: source distribution unstable
 dpkg-source --before-build nodejs-6.12.0~dfsg
dpkg-buildpackage: info: host architecture powerpc
 fakeroot debian/rules clean
debian/rules:72: *** "nodejs cannot run on powerpc, please consult maintainers".  Stop.
dpkg-buildpackage: error: fakeroot debian/rules clean subprocess returned exit status 2

Since the list of supported architectures is known, the correct way to
limit the build architectures is to use a white-list for the individual
packages in debian/control. This will also avoid useless build attempts
on the buildds which saves CPU time and electricity!

Use the Architecture field to list the architectures, separate by spaces
which are supported for a particular package. The attached patch should
do the right thing.

Thanks,
Adrian

> [1] https://buildd.debian.org/status/package.php?p=nodejs&suite=sid

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
-------------- next part --------------
>From 904894c5d5e4d1801578a835833759f8e432e3c2 Mon Sep 17 00:00:00 2001
From: John Paul Adrian Glaubitz <glaubitz at physik.fu-berlin.de>
Date: Tue, 14 Nov 2017 16:51:15 +0100
Subject: [PATCH] Use architecture white-list for binary packages

---
 debian/control.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/control.in b/debian/control.in
index f62de8b2..5b628adb 100644
--- a/debian/control.in
+++ b/debian/control.in
@@ -15,7 +15,7 @@ Vcs-Git: https://anonscm.debian.org/git/collab-maint/nodejs.git
 Package: nodejs-dev
 Section: devel
 Priority: extra
-Architecture: !armel
+Architecture: amd64 arm64 armhf i386 mips mips64el mipsel ppc64 ppc64el s390x
 Depends: ${cdbs:Depends},
  ${misc:Depends},
  nodejs (= ${binary:Version})
@@ -30,7 +30,7 @@ Description: evented I/O for V8 javascript (development files)
  This package is needed to build plugins.
 
 Package: nodejs
-Architecture: !armel
+Architecture: amd64 arm64 armhf i386 mips mips64el mipsel ppc64 ppc64el s390x
 Depends: ${shlibs:Depends},
  ${misc:Depends}
 Provides: ${cdbs:Provides}
-- 
2.11.0