[Pkg-javascript-devel] Bug#917668: nodejs: FTBFS: ../src/node_i18n.cc:526:12: error: 'TimeZone' has not been declared

[Lucas Nussbaum]

Source: nodejs
Version: 8.11.2~dfsg-1
Severity: serious
Justification: FTBFS on amd64
Tags: buster sid
Usertags: ftbfs-20181229 ftbfs-buster

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

Relevant part (hopefully):
>   g++ -o /<<PKGBUILDDIR>>/out/Release/obj.target/node_lib/src/node_i18n.o ../src/node_i18n.cc '-DNODE_OPENSSL_CERT_STORE' '-DNODE_ARCH="x64"' '-DNODE_PLATFORM="linux"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' '-DNODE_OPENSSL_SYSTEM_CERT_PATH=""' '-DHAVE_INSPECTOR=1' '-D__POSIX__' '-DNODE_USE_V8_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DHAVE_OPENSSL=1' -I../src -I/<<PKGBUILDDIR>>/out/Release/obj/gen -I/<<PKGBUILDDIR>>/out/Release/obj/gen/include -I../deps/v8/include  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++0x -MMD -MF /<<PKGBUILDDIR>>/out/Release/.deps//<<PKGBUILDDIR>>/out/Release/obj.target/node_lib/src/node_i18n.o.d.raw -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -g -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -specs=/usr/share/dpkg/no-pie-compile.specs -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -g -c
> ../deps/v8/include/v8.h: In instantiation of 'void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = node::{anonymous}::ZCtx; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<node::{anonymous}::ZCtx>&)]':
> ../src/base-object-inl.h:80:3:   required from 'void node::BaseObject::MakeWeak(Type*) [with Type = node::{anonymous}::ZCtx]'
> ../src/node_zlib.cc:89:24:   required from here
> ../deps/v8/include/v8.h:9253:16: warning: cast between incompatible function types from 'v8::WeakCallbackInfo<node::{anonymous}::ZCtx>::Callback' {aka 'void (*)(const v8::WeakCallbackInfo<node::{anonymous}::ZCtx>&)'} to 'Callback' {aka 'void (*)(const v8::WeakCallbackInfo<void>&)'} [-Wcast-function-type]
>                 reinterpret_cast<Callback>(callback), type);
>                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from ../src/node.h:63,
>                  from ../src/node_internals.h:27,
>                  from ../src/node_i18n.h:27,
>                  from ../src/node_i18n.cc:43:
> ../deps/v8/include/v8.h: In static member function 'static void v8::V8::SetAllowCodeGenerationFromStringsCallback(v8::DeprecatedAllowCodeGenerationFromStringsCallback)':
> ../deps/v8/include/v8.h:10230:19: warning: cast between incompatible function types from 'v8::DeprecatedAllowCodeGenerationFromStringsCallback' {aka 'bool (*)(v8::Local<v8::Context>)'} to 'v8::FreshNewAllowCodeGenerationFromStringsCallback' {aka 'bool (*)(v8::Local<v8::Context>, v8::Local<v8::String>)'} [-Wcast-function-type]
>            callback));
>                    ^
> ../deps/v8/include/v8.h: In static member function 'static void v8::V8::RemoveGCPrologueCallback(v8::GCCallback)':
> ../deps/v8/include/v8.h:10275:53: warning: cast between incompatible function types from 'v8::GCCallback' {aka 'void (*)(v8::GCType, v8::GCCallbackFlags)'} to 'v8::Isolate::GCCallback' {aka 'void (*)(v8::Isolate*, v8::GCType, v8::GCCallbackFlags)'} [-Wcast-function-type]
>        reinterpret_cast<Isolate::GCCallback>(callback));
>                                                      ^
> ../deps/v8/include/v8.h: In static member function 'static void v8::V8::RemoveGCEpilogueCallback(v8::GCCallback)':
> ../deps/v8/include/v8.h:10282:53: warning: cast between incompatible function types from 'v8::GCCallback' {aka 'void (*)(v8::GCType, v8::GCCallbackFlags)'} to 'v8::Isolate::GCCallback' {aka 'void (*)(v8::Isolate*, v8::GCType, v8::GCCallbackFlags)'} [-Wcast-function-type]
>        reinterpret_cast<Isolate::GCCallback>(callback));
>                                                      ^
> ../src/node_i18n.cc: In function 'const char* node::i18n::{anonymous}::GetVersion(const char*, char*, UErrorCode*)':
> ../src/node_i18n.cc:526:12: error: 'TimeZone' has not been declared
>      return TimeZone::getTZDataVersion(*status);
>             ^~~~~~~~
> In file included from ../src/node.h:63,
>                  from ../src/node_internals.h:27,
>                  from ../src/node_i18n.h:27,
>                  from ../src/node_i18n.cc:43:
> ../deps/v8/include/v8.h: In instantiation of 'void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = node::i18n::{anonymous}::ConverterObject; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<node::i18n::{anonymous}::ConverterObject>&)]':
> ../src/base-object-inl.h:80:3:   required from 'void node::BaseObject::MakeWeak(Type*) [with Type = node::i18n::{anonymous}::ConverterObject]'
> ../src/node_i18n.cc:261:35:   required from here
> ../deps/v8/include/v8.h:9253:16: warning: cast between incompatible function types from 'v8::WeakCallbackInfo<node::i18n::{anonymous}::ConverterObject>::Callback' {aka 'void (*)(const v8::WeakCallbackInfo<node::i18n::{anonymous}::ConverterObject>&)'} to 'Callback' {aka 'void (*)(const v8::WeakCallbackInfo<void>&)'} [-Wcast-function-type]
>                 reinterpret_cast<Callback>(callback), type);
>                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../src/node_i18n.cc: In function 'int node::i18n::GetColumnWidth(UChar32, bool)':
> ../src/node_i18n.cc:788:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>        if (ambiguous_as_full_width) {
>        ^~
> ../src/node_i18n.cc:792:5: note: here
>      case U_EA_NEUTRAL:
>      ^~~~
> make[2]: *** [node_lib.target.mk:161: /<<PKGBUILDDIR>>/out/Release/obj.target/node_lib/src/node_i18n.o] Error 1

The full build log is available from:
   http://aws-logs.debian.net/2018/12/29/nodejs_8.11.2~dfsg-1_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.