[Pkg-javascript-devel] Bug#890945: node-temporary: auotpkgtest broken with nodejs 8.9 due to deprecation warnings

[Steve Langasek]

Package: node-temporary
Version: 0.0.8-2
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu bionic ubuntu-patch autopkgtest

Dear Private,

With the update to nodejs 8.9.3, the autopkgtest for node-temporary fails in
Debian and Ubuntu due to deprecation warnings on stderr:

[...]
autopkgtest [08:28:30]: test command1:  - - - - - - - - - - results - - - - - - - - - -
command1             FAIL stderr: (node:11230) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.
autopkgtest [08:28:30]: test command1:  - - - - - - - - - - stderr - - - - - - - - - -
(node:11230) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.
(node:11230) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.
(node:11230) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.
(node:11230) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.
(node:11230) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.
[...]

While the test failure is (unfortunately) not considered a blocker for
Debian testing, autopkgtest regressions are blockers for Ubuntu releases.

I have examined the warnings and determined that they originate with the
test suite itself, not with the code under test, so I think a reasonable
solution is to allow-stderr from this autopkgtest.  Please see the attached
patch.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru node-temporary-0.0.8/debian/tests/control node-temporary-0.0.8/debian/tests/control
--- node-temporary-0.0.8/debian/tests/control	2016-12-13 02:11:38.000000000 -0800
+++ node-temporary-0.0.8/debian/tests/control	2018-02-20 13:13:51.000000000 -0800
@@ -3,3 +3,4 @@
 
 Test-Command: make test
 Depends: @, @builddeps@
+Restrictions: allow-stderr