[Pkg-javascript-devel] Bug#897156: Bug#897156: node-cache-base: FTBFS and Debci failure with node-is-extendable 1.0.1-1

[Paolo Greppi]

Il 29/04/2018 09:29, Adrian Bunk ha scritto:
> Source: node-cache-base
> Version: 0.8.4-1
> Severity: serious
> 
> https://ci.debian.net/packages/n/node-cache-base/unstable/amd64/
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/node-cache-base.html
> 
> ...
>   39 passing (460ms)
>   5 failing
> 
>   1) cache-base
>        .union()
>          should union a string value:
>      TypeError: union-value expects the first argument to be an object.
>       at Function.unionValue (/usr/lib/nodejs/union-value/index.js:10:11)
>       at Cache.union (index.js:111:11)
>       at Context.<anonymous> (test/test.js:69:11)
>       at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21)
>       at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
>       at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
>       at /usr/lib/nodejs/mocha/lib/runner.js:560:12
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
>       at /usr/lib/nodejs/mocha/lib/runner.js:366:7
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
>       at Immediate.<anonymous> (/usr/lib/nodejs/mocha/lib/runner.js:334:5)
> 
>   2) cache-base
>        .union()
>          should union multiple string values:
>      TypeError: union-value expects the first argument to be an object.
>       at Function.unionValue (/usr/lib/nodejs/union-value/index.js:10:11)
>       at Cache.union (index.js:111:11)
>       at Context.<anonymous> (test/test.js:74:11)
>       at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21)
>       at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
>       at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
>       at /usr/lib/nodejs/mocha/lib/runner.js:560:12
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
>       at /usr/lib/nodejs/mocha/lib/runner.js:366:7
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
>       at Immediate.<anonymous> (/usr/lib/nodejs/mocha/lib/runner.js:334:5)
> 
>   3) cache-base
>        .union()
>          should union multiple arrays:
>      TypeError: union-value expects the first argument to be an object.
>       at Function.unionValue (/usr/lib/nodejs/union-value/index.js:10:11)
>       at Cache.union (index.js:111:11)
>       at Context.<anonymous> (test/test.js:81:11)
>       at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21)
>       at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
>       at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
>       at /usr/lib/nodejs/mocha/lib/runner.js:560:12
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
>       at /usr/lib/nodejs/mocha/lib/runner.js:366:7
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
>       at Immediate.<anonymous> (/usr/lib/nodejs/mocha/lib/runner.js:334:5)
> 
>   4) cache-base
>        .union()
>          should union nested string values:
>      TypeError: union-value expects the first argument to be an object.
>       at Function.unionValue (/usr/lib/nodejs/union-value/index.js:10:11)
>       at Cache.union (index.js:111:11)
>       at Context.<anonymous> (test/test.js:88:11)
>       at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21)
>       at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
>       at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
>       at /usr/lib/nodejs/mocha/lib/runner.js:560:12
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
>       at /usr/lib/nodejs/mocha/lib/runner.js:366:7
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
>       at Immediate.<anonymous> (/usr/lib/nodejs/mocha/lib/runner.js:334:5)
> 
>   5) cache-base
>        .union()
>          should union and uniquify arrays:
>      TypeError: union-value expects the first argument to be an object.
>       at Function.unionValue (/usr/lib/nodejs/union-value/index.js:10:11)
>       at Cache.union (index.js:111:11)
>       at Context.<anonymous> (test/test.js:95:11)
>       at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21)
>       at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
>       at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
>       at /usr/lib/nodejs/mocha/lib/runner.js:560:12
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
>       at /usr/lib/nodejs/mocha/lib/runner.js:366:7
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
>       at Immediate.<anonymous> (/usr/lib/nodejs/mocha/lib/runner.js:334:5)
> 
> 
> 
> make[1]: *** [debian/rules:13: override_dh_auto_test] Error 5

Thanks for finding this one so quick !

I remember testing all rdepends of node-is-extendable prior to the RFS:
https://alioth-lists.debian.net/pipermail/pkg-javascript-devel/2018-April/025848.html

And indeed all 5 passed:
- node-clone-deep
- node-extend-shallow
- node-mixin-deep
- node-object.omit
- node-union-value.

But node-cache-base is a reverse dependency of node-union-value so meta/build did not test it !

Version 2.0.2 which is in the VCS (and was on hold till node-base 1.0.1-1 could be uploaded) is also affected so it does not help.

I tried upgrading it to 4.0.0 but that requires:
- updating node-get-value 2.0.6-1 -> 3.0.1
- packaging node-has-own-deep
- updating node-set-value 0.4.0-1 -> 3.0.0
Anyway I gave it a quick try:
npm install has-own-deep
mocha -R spec
...
61 passing (53ms)
and the tests do pass with version 4.0.0 ...

The real trouble is that it would also require updating its only rdepend node-base to 3.0.0 which is blocked, see:
https://bugs.debian.org/887497

Paolo