[Pkg-javascript-devel] Bug#890539: RFS: node-yamljs/0.3.0+dfsg-1 [ITP]

[Bastien ROUCARIES]

On Sun, May 13, 2018 at 5:17 PM, Andreas Moog <andreas.moog at warperbbs.de> wrote:
> Hi there,
>
> I have updated the packaging in the salsa repo
> (https://salsa.debian.org/js-team/node-yamljs) and on mentors. If any of you
> could give me a review or sponsor this package it would be greatly appreciated!

1. you need a smoke test : aka run a json file and convert to yaml.
create a debian/smoketest dir and put file here
2. why did you not run testsuite ?
3 copyright is not good run on github tree
git log gihtub/master  --format="%an <%ae>" |  sort -u
4. copyright year are 2010-2017
5 install is not right you need only to install index.js and lib/ cli/
package.json files under nodes dir
6. you should also exclude lib if you rebuilt it under copyright file-excluded:
7. demo.html should be ship with dh_examples
8. to be completed after these steps

Thanks Bastien (rouca at debian.org)

Will sponsor

> Viele Grüße // Best regards
>
> Andreas
>
> --
> PGP-encrypted mails preferred
> PGP Fingerprint: 74CD D9FE 5BCB FE0D 13EE 8EEA 61F3 4426 74DE 6624
>
> --
> Pkg-javascript-devel mailing list
> Pkg-javascript-devel at alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel