[Pkg-javascript-devel] Bug#897536: mustache.js: FTBFS: make[1]: rake: Command not found

[Pierre-Elliott Bécue]

Le vendredi 11 mai 2018 à 12:12:44+0200, Jonas Meurer a écrit :
> Control: tag -1 +moreinfo
> 
> Hello,
> 
> I just tried to reproduce the FTBFS and failed. rake is defined as
> build-dependency and correctly pulled in according to linked the build logs.
> 
> My best guess is that rake 12.3.1-2 had some bug that got fixed in 12.3.1-3.
> 
> Lucas, could you trigger another rebuild to see whether this got fixed
> by the latest rake upload?
> 
> In any case, it doesn't look like a bug in mustache.js package to me.
> 
> Cheers,

Indeed the rake issue is gone with the latest upload of rake.

Yet, [1] shows that mustache.js still FTBFS.

The reason seems to be that the mustache.js CLI takes too much time to do
its job in some tests on the build servers of the reproducible-builds
project. As the timeout of mocha testsuite is 2s, this leads to some
failures.

A fix should be designed. I see two solutions:

 1) In all describe statements of cli-test.js[2], add a more reasonable
    timeout delay to mocha, such as
    """
    describe('Mustache CLI', function () {
    this.timeout(5000);
    var expectedOutput;
    […]
    """
 2) Disable these tests.

It should be noted that tests that may fail based on a time-dependency
(timeout, time-based tests) are not fit for reproducibility tests.

Cheers.

[1] https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/mustache.js.html
[2] https://github.com/janl/mustache.js/blob/master/test/cli-test.js

-- 
Pierre-Elliott Bécue
GPG: 9AE0 4D98 6400 E3B6 7528  F493 0D44 2664 1949 74E2
It's far easier to fight for one's principles than to live up to them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20180514/8e820c25/attachment.sig>