[Pkg-javascript-devel] Review of istanbuljs packaging

[Per Andersson]

Hi!

Good packaging work with istanbuljs!

I realised that it was probably too much for IRC...

A more digestable list:

node-append-transform and node-default-require-extensions:
* Strip #readme from homepage url in d/copyright and d/control
* Add yourself to Uploaders in d/control
* You may include notes.md in d/docs
* d/changelog should close ITP bug
* Clean up d/rules to remove unused dh override targets
* Copyright should include all copyrightable years

node-async:
* Document everything you have done in d/changelog, e.g.:
  * Add node-babel-plugin-add-module-exports dependency
  * Bump Standards-Version to 4.2.1, no changes needed (or describe what
    changes were made)
  * Changing Vcs-* urls to Salsa
  * Updated d/copyright, removed deps/nodeunit.js
  * Why is lintian override source-is-missing necessary?
* In the commit 1f1a73863e91c7101df3c114ed5e4c967391dd24 there is more
  happening than just changing the .gitignore
* In the commit 7ef4626a5b559c52d13ed5fa57110fe8bfd77027 why does the
  target path need changing?
* It seems you have not committed the orig.tar.gz to the pristine-tar
  branch. did you forget to push upstream and pristine-tar branches?

node-fileset:
* Why do you use debhelper 10? debhelper 11 is recommended.
* d/changelog should close ITP | bug
* remove override_dh_auto_build target if unused
* aren't node-glob and node-minimatch required to run tests? I.e. they
  need to be in Build-Dependency.
* Copyright should include all copyrightable years

node-path-parse:
* d/changelog should close ITP bug
* Strip #readme from upstream homepage in d/copyright and d/control
* Long description is missing in d/control
* You could add an autopkgtest running node test.js,
* Copyright for upstream should probably be 2015-2018, not only 2018,
  per github commits.
* Copyright should include all copyrightable years

node-istanbuljs-1.x:
* d/copyright is not complete, run `licensecheck --deb-machine -r -l0 *`
  for hints
* Missing long descriptions in d/control
* It's customary to use the same license as upstream for debian/*
* debian/watch file does not work


--
Per