[Pkg-javascript-devel] Bug#935016: pkg-js-tools: An unannounced change in "debhelper" breaks pkg-js-tools

[Xavier]

Le 18/08/2019 à 08:08, Niels Thykier a écrit :
> Control: tags -1 moreinfo
> 
> On Sun, 18 Aug 2019 07:55:59 +0200 Xavier Guimard <yadd at debian.org> wrote:
>> Package: pkg-js-tools
>> Version: 0.9.5
>> Severity: grave
>> Justification: renders package unusable
>>
>> pkg-js-tools was based on add_command_options which disappears in
>> Debhelper 12.5.1. This renders pkg-js-tools unusable.
>>
>>
> 
> Hi,
> 
> No, add_command_options has not been (intentionally?) removed in
> debhelper 12.5.1.
> 
> Could you please clarify what made you file this bug?  Did you get an
> error/did something break?
> 
> Thanks,
> ~Niels

Hi,

pkg-js-tools "Sequence" is simply:

  #!/usr/bin/perl
  # debhelper sequence file

  use warnings;
  use strict;
  use Debian::Debhelper::Dh_Lib;

  add_command_options("dh_auto_test", "--buildsystem=nodejs");
  add_command_options("dh_auto_configure", "--buildsystem=nodejs");
  add_command_options("dh_auto_build", "--buildsystem=nodejs");
  add_command_options("dh_auto_install", "--buildsystem=nodejs");
  add_command_options("dh_auto_clean", "--buildsystem=nodejs");

Works fine until debhelper 12.5. Then dh returns:

  dh: unable to load addon nodejs: Debian/Debhelper/Sequence/nodejs.pm
      did not return a true value at (eval 13) line 1.
  BEGIN failed--compilation aborted at (eval 13) line 1.


Next debug:
  # perl -le 'use Debian::Debhelper::Sequence::nodejs'
  Undefined subroutine &main::add_command_options called at
 /usr/share/perl5/Debian/Debhelper/Sequence/nodejs.pm line 8.


I think I have to change to "insert_before" commands, isn't it ?