[Pkg-javascript-devel] Bug#932956: ITP: node-node-sass -- Wrapper around libsass

[Xavier]

Le 25/08/2019 à 05:29, Nilesh Patra a écrit :
> 
> 
> 
>     > You didn't check debian/copyright, many things are missing. Please
>     take
>     > a look at this patch
> 
>     At least get-stdin pristine-tar files are missing
> 
> I rectified the debian/copyright file, and pushed. Could you please
> review, now?
> Also, I do see the get-stdin delta and id files in the pristine-tar
> branch of the repository. However, I also see the in-publish repository
> delta and id files still present in the pristine-tar branch. Is there a
> way to remove them? Simple doing `git rm <files>` isn't removing them.
> Do I need to manually remove them, and commit, or is there a work-around
> for the same?
> Please do let me know the answers to these doubts.
> Thanks and Regards
> Nilesh

 * sass-spec is a dev dependency: no need to install it
 * don't use lintian-overrides to hide some real problems (fixed by ^)
 * never set an empty debian/tests/pkg-js/test: this produces a bad
   autopkgtest report (success while no test where played)
 * enabling test shows that sass-spec isn't compatible (good version is
   3.5.4-1, not 3.5.4
 * "src" dir contains only cpp files => not installed
 * debian/clean was missing
 * /usr/bin/node-sass was a bad link. I added a feature in pkg-js-tools
   0.9.8 to help here

I pushed all in js-team/node-node-sass. Please review my changes