[Pkg-javascript-devel] Bug#932956: ITP: node-node-sass -- Wrapper around libsass

[Nilesh Patra]

>>       * sass-spec is a dev dependency: no need to install it
>>      * don't use lintian-overrides to hide some real problems (fixed by
^)
>>      * never set an empty debian/tests/pkg-js/test: this produces a bad
>>        autopkgtest report (success while no test where played)
>>      * enabling test shows that sass-spec isn't compatible (good version
is
>>        3.5.4-1, not 3.5.4
>>      * "src" dir contains only cpp files => not installed
>>      * debian/clean was missing
>>      * /usr/bin/node-sass was a bad link. I added a feature in
pkg-js-tools
>>        0.9.8 to help here
>>
>>     I pushed all in js-team/node-node-sass. Please review my changes
>>
>>
>> Thanks for pushing the changes:)
>> I had some doubts, and it would be great if you could clarify them(I
>> apologize if they sound like a very newbie doubt):
>>
>>    * How to the exact version of each package that should be used, and
>> also what modules should be embedded for the package to be built?.(I do
>> it by seeing the build logs, it however seems that they aren't accurate
>> to judge the depends)
>
> I used "npm install" to make test work, then I searched what was the
> difference with current failing test
>
>>    * What exactly are upstream test? and how are they different from
>> autopkgtests?
>
> autopkgtest is a Debian framework that relaunches test on installed
> files. Upstream test is the test given in package.json#test (here mocha)
>
>>    * How is debian/nodejs/files different from debian/install ?
>
> debian/nodejs/files overrides package.json#files used by
> pkg-js-tools/dh_auto_install to know which files have to be installed
>
> debian/install is not used here since we have a dh_auto_install.
> debian/install is a manual install
>
>>    * `"src" dir contains only cpp files => not installed` : I didn't
>> understand the reason completely, would you mind explaining it a little
>> more?
>
> cpp files are useful only for build. A Debian package usually provides
> usable files not source ones
>
>>    * What exactly is a 'bad link'? And how to know if a particular link
>> is bad or not?
>
> /usr/bin/node-sass was linked to a non existent file
>
>>    * The pristine-tar branch contains the in-publish files, is there a
>> way to un-commit them?
>
> Simply:
> $ git checkout pristine-tar
> $ ls
> $ git rm <unwanted files>
> $ git commit -a -m 'Remove useless files'
> $ git checkout master


Thanks a lot! :)
If everything looks fine to you, could you upload the package? (I needed
this for node-mermaid)

Thanks and Regards
Nilesh

On Sun, 25 Aug 2019, 14:27 Xavier, <yadd at debian.org> wrote:

> Le 25/08/2019 à 10:45, Nilesh Patra a écrit :
> >
> >
> >
> >       * sass-spec is a dev dependency: no need to install it
> >      * don't use lintian-overrides to hide some real problems (fixed by
> ^)
> >      * never set an empty debian/tests/pkg-js/test: this produces a bad
> >        autopkgtest report (success while no test where played)
> >      * enabling test shows that sass-spec isn't compatible (good version
> is
> >        3.5.4-1, not 3.5.4
> >      * "src" dir contains only cpp files => not installed
> >      * debian/clean was missing
> >      * /usr/bin/node-sass was a bad link. I added a feature in
> pkg-js-tools
> >        0.9.8 to help here
> >
> >     I pushed all in js-team/node-node-sass. Please review my changes
> >
> >
> > Thanks for pushing the changes:)
> > I had some doubts, and it would be great if you could clarify them(I
> > apologize if they sound like a very newbie doubt):
> >
> >    * How to the exact version of each package that should be used, and
> > also what modules should be embedded for the package to be built?.(I do
> > it by seeing the build logs, it however seems that they aren't accurate
> > to judge the depends)
>
> I used "npm install" to make test work, then I searched what was the
> difference with current failing test
>
> >    * What exactly are upstream test? and how are they different from
> > autopkgtests?
>
> autopkgtest is a Debian framework that relaunches test on installed
> files. Upstream test is the test given in package.json#test (here mocha)
>
> >    * How is debian/nodejs/files different from debian/install ?
>
> debian/nodejs/files overrides package.json#files used by
> pkg-js-tools/dh_auto_install to know which files have to be installed
>
> debian/install is not used here since we have a dh_auto_install.
> debian/install is a manual install
>
> >    * `"src" dir contains only cpp files => not installed` : I didn't
> > understand the reason completely, would you mind explaining it a little
> > more?
>
> cpp files are useful only for build. A Debian package usually provides
> usable files not source ones
>
> >    * What exactly is a 'bad link'? And how to know if a particular link
> > is bad or not?
>
> /usr/bin/node-sass was linked to a non existent file
>
> >    * The pristine-tar branch contains the in-publish files, is there a
> > way to un-commit them?
>
> Simply:
> $ git checkout pristine-tar
> $ ls
> $ git rm <unwanted files>
> $ git commit -a -m 'Remove useless files'
> $ git checkout master
>
> > Thanks and Regards
> > Nilesh
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20190825/2797aa99/attachment.html>