[Pkg-javascript-devel] Bug#935831: node-turbolinks: Incorrect symlink to /usr/lib in /usr/share/javascript

[Sunil Mohan Adapa]

Package: node-turbolinks
Version: 5.1.1+dfsg-5
Severity: important
Tags: patch

Dear Maintainer,

In the latest version of node-turbolinks (5.1.1+dfsg-5), the files are being
installed in /usr/share instead of /usr/lib. However, the link in the directory
/usr/share/javascript/turbolinks has not been updated to reflect the new path.
Due to this, package users (like FreedomBox) trying to access the library using
the URL http://localhost/javascript/turbolinks/turbolinks.js get an error. This
path is provided by Apache configuration snippet in the javascript-common
package.

Workaround for users is to run:
rm -f /usr/share/javascript/turbolinks/turbolinks.js
ln -rs /usr/share/nodejs/turbolinks/dist/turbolinks.js
/usr/share/javascript/turbolinks/turbolinks.js

The following patch fixes the problem:
https://salsa.debian.org/js-team/node-turbolinks/merge_requests/2

Please consider making a release with the fix soon as major functionality is
broken in FreedomBox.

Thank you for packaging node-turbolinks,

--
Sunil



-- System Information:
Debian Release: 10.0
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_IN.UTF-8, LC_CTYPE=en_IN.UTF-8 (charmap=UTF-8), LANGUAGE=en_IN.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-------------- next part --------------
>From d1b69c2d2055d54a1a113caf17ecbf02be694523 Mon Sep 17 00:00:00 2001
From: Sunil Mohan Adapa <sunil at medhas.org>
Date: Mon, 26 Aug 2019 10:50:40 -0700
Subject: [PATCH] Fix incorrect symlink to /usr/lib in /usr/share/javascript

Without the change turbolinks is no longer accessible on
http://localhost/javascript/turbolinks/turbolinks.js . This was possible due to
Apache configuration snippet provided by javascript-common package.

Tests:

- Build package with changes using pbuilder, install and access the URL
  http://localhost/javascript/turbolinks/turbolinks.js

Signed-off-by: Sunil Mohan Adapa <sunil at medhas.org>
---
 debian/links | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/links b/debian/links
index 0d266f4..9609ccd 100644
--- a/debian/links
+++ b/debian/links
@@ -1 +1 @@
-usr/lib/nodejs/turbolinks/dist/turbolinks.js usr/share/javascript/turbolinks/turbolinks.js
+usr/share/nodejs/turbolinks/dist/turbolinks.js usr/share/javascript/turbolinks/turbolinks.js
-- 
2.20.1