[Pkg-javascript-devel] Bug#921384: Bug#921384: node-stringprep breaks node-xmpp autopkgtest

[Paolo Greppi]

Il 04/02/19 22:01, Jérémy Lal ha scritto:
> Le lun. 4 févr. 2019 à 21:51, Paul Gevers <elbrus at debian.org <mailto:elbrus at debian.org>> a écrit :
> 
> ...
>     With a recent upload of node-stringprep the autopkgtest of node-xmpp
>     fails in testing when that autopkgtest is run with the binary packages
>     of node-stringprep from unstable. It passes when run with only packages
>     from testing. In tabular form:
> ...
> 
> I started investigations about node-stringprep failure and while the fix is probably
> one line somewhere, it's hard to find it (nodejs cannot load the module, it falls back to
> a default useless behavior).

it fails with node-stringprep from unstable (0.8.0-5)
it passes with node-stringprep from testing (0.8.0-4)

the only significant difference I see is switching from nodejs-dev to libnode-dev

git diff debian/0.8.0-4 debian/0.8.0-5

diff --git a/debian/changelog b/debian/changelog
index 8593d15..b486302 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+node-stringprep (0.8.0-5) unstable; urgency=medium
+
+  [ Gianfranco Costamagna ]
+  * Team upload
+
+  [ Xavier Guimard ]
+  * Fix cdbs files
+
+ -- Gianfranco Costamagna <locutusofborg at debian.org>  Thu, 31 Jan 2019 13:58:51 +0100
+
 node-stringprep (0.8.0-4) unstable; urgency=medium
 
   * Team upload
diff --git a/debian/control b/debian/control
index 1c493ce..1e85350 100644
--- a/debian/control
+++ b/debian/control
@@ -5,7 +5,7 @@ Maintainer: Debian Javascript Maintainers <pkg-javascript-devel at lists.alioth.deb
 Uploaders: Jonas Smedegaard <dr at jones.dk>
 Build-Depends: cdbs,
  licensecheck,
- debhelper,
+ debhelper (>= 10~),
  dh-buildinfo,
  libnode-dev,
  node-gyp (>= 3.8.0-2),
diff --git a/debian/rules b/debian/rules
index f7c71dd..fbbd7d3 100755
--- a/debian/rules
+++ b/debian/rules
@@ -26,7 +26,7 @@ pkg = node-node-stringprep
 libdir = /usr/lib/nodejs/node-stringprep
 
 # Needed by upstream build
-bdeps = nodejs-dev, node-gyp, node-nan (>= 2.3.3), libicu-dev
+bdeps = libnode-dev, node-gyp (>= 3.8.0-2), node-nan (>= 2.3.3), libicu-dev
 
 # Needed at runtime
 depends = nodejs, node-bindings (>= 1.2.1), node-debug