[Pkg-javascript-devel] Bug#896468: Bug#896468: Bug#896468: libjs-chartjs: Please upload newer versions

[Pirate Praveen]

On Sun, Feb 17, 2019 at 2:47 AM, Paul Gevers <elbrus at debian.org> wrote:
> Hi,
> 
> On 15-02-2019 07:46, Pirate Praveen wrote:
>>  Thanks Jonas for the confirmation. I have uploaded 2.7.3 to
>>  experimental. Since browserify is not available in the archive, I 
>> have
>>  used rollup to build the umd bundle. Please review, test and 
>> confirm if
>>  it is working as expected and I can upload to unstable.
> 
> I must admit that I don't know how to program in JavaScript, but if I
> compare the upstream version of 2.7.3 [1] with the one in 
> experimental,
> I am missing already the first function that I see upstream, i.e.
> getRgba().
> 
> I expect that is not ok, no?
> 

Thanks Paul for testing. The missing dependencies were treated as 
external dependencies by rollup (webpack would give an error), would 
have worked in node, but not in browser. I embedded the missing 
dependencies and also used rollup-plugin-node-resolve to include all 
dependencies in the bundle. So please test 2.7.3+dfsg-2 and confirm if 
it is working as expected (for gitlab, I still don't use the packaged 
version, so can't really test now).

I can now see 'function getRgba(string) {' in the built bundle.

> Also the file looks quite different, but I guess that is to be 
> expected
> due to build system differences.

As long as it is working as expected, the exact match is not required. 
Each build tool has their on signature styles for bundling.