[Pkg-javascript-devel] review node-braces 2.3.1 with pkg-component setup

[Jonas Smedegaard]

Hi Paolo,

Quoting Paolo Greppi (2019-01-08 17:11:16)
> While updating node-braces from 2.0.2 to 2.3.1, I found that the node-split-string version that we have in debian (6.0.0-1) breaks it (it only works with 3.0.2).
> To see how it breaks it (779/944 tests fail), you can have a look at a failed CI run:
> https://salsa.debian.org/js-team/node-braces/-/jobs/103300
> 
> Since upstream is not willing to upgrade braces to use split-string 6.0.0 (https://github.com/micromatch/braces/issues/19) nor am I, I opted to embed split-string 3.0.2 (and assign-symbols that is for some mysterious reason also required), using the pkg-components procedure:
> https://wiki.debian.org/Javascript/Nodejs/Npm2Deb/Embedding
> 
> Since this is the 1st time I apply this procedure, I would appreciate if someone could review it:
> https://salsa.debian.org/js-team/node-braces

Do I understand correctly, that you embed libraries not because they are 
too tiny to be sensible to distribute alone in Debian, but because 
recent releases of (one of) those libraries cause testsuite failures and 
(upstream and) you don't want to patch testsuite?


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20190108/39d8f270/attachment.sig>