[Pkg-javascript-devel] review node-braces 2.3.1 with pkg-component setup

[Pirate Praveen]

On Tue, Jan 8, 2019 at 9:41 PM, Paolo Greppi <paolo.greppi at libpf.com> 
wrote:
> While updating node-braces from 2.0.2 to 2.3.1, I found that the 
> node-split-string version that we have in debian (6.0.0-1) breaks it 
> (it only works with 3.0.2).
> To see how it breaks it (779/944 tests fail), you can have a look at 
> a failed CI run:
> https://salsa.debian.org/js-team/node-braces/-/jobs/103300
> 
> Since upstream is not willing to upgrade braces to use split-string 
> 6.0.0 (https://github.com/micromatch/braces/issues/19) nor am I, I 
> opted to embed split-string 3.0.2 (and assign-symbols that is for 
> some mysterious reason also required), using the pkg-components 
> procedure:
> https://wiki.debian.org/Javascript/Nodejs/Npm2Deb/Embedding
> 
> Since this is the 1st time I apply this procedure, I would appreciate 
> if someone could review it:
> https://salsa.debian.org/js-team/node-braces
> 

Looks good to me.