[Pkg-javascript-devel] RFS: node-define-property 2.0.2+~1.0.2-1

[Xavier]

Le 30/01/2019 à 18:11, Xavier a écrit :
> Le 30/01/2019 à 15:20, Paolo Greppi a écrit :
>> Hi, I have prepared an update to node-define-property.
>>
>> It fixes RC bug https://bugs.debian.org/892656 by embedding the right versions
>> of:
>> - is-accessor-descriptor (1.0.0)
>> - is-data-descriptor (1.0.0)
>> - is-descriptor (1.0.2)
>> see option 2 here:
>> https://alioth-lists.debian.net/pipermail/pkg-javascript-devel/2019-January/030664.html
>>
>> All three qualify for embedding: they are tiny (total 87 LOC), and require no
>> build step.
>> Besides, they are all from the same author and have the same license.
>> Once this version of node-define-property lands in testing, we can remove
>> node-is-accessor-descriptor, node-is-data-descriptor and node-is-descriptor
>> (they have no other rdep).
>>
>> Even if the major version changes, according to CHANGELOG nothing has been
>> dropped from the API of define-property.
>> And indeed all reverse dependencies (node-base node-braces node-class-utils
>> node-expand-brackets node-extglob node-object-copy node-snapdragon
>> node-snapdragon-node node-static-extend node-to-regex) pass autopkgtests and
>> the reverse build dependencies (node-base node-braces node-class-utils
>> node-extglob node-object-copy node-snapdragon node-static-extend node-to-regex
>> node-use) build fine.
>>
>> Please someone sponsor the upload:
>> https://salsa.debian.org/js-team/node-define-property
>>
>> Paolo
> 
> Hello,
> 
> I fixed some things. Anyway, build fails for now:
> 
>   4 passing (28ms)
>   4 failing
> 
>   1) define
>        should define a property with accessor descriptors::
> 
>       AssertionError [ERR_ASSERTION]: 'bar' == 'baz'
>       + expected - actual
> 
>       -bar
>       +baz
> 
>       at Context.<anonymous> (test.js:40:12)
>       at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21)
>       at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
>       at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
>       at /usr/lib/nodejs/mocha/lib/runner.js:560:12
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
>       at /usr/lib/nodejs/mocha/lib/runner.js:366:7
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
>       at Immediate._onImmediate (/usr/lib/nodejs/mocha/lib/runner.js:334:5)
> 
>   2) define
>        should define a property on a function:
> 
>       AssertionError [ERR_ASSERTION]: 'bar' == 'baz'
>       + expected - actual
> 
>       -bar
>       +baz
> 
>       at Context.<anonymous> (test.js:56:12)
>       at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21)
>       at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
>       at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
>       at /usr/lib/nodejs/mocha/lib/runner.js:560:12
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
>       at /usr/lib/nodejs/mocha/lib/runner.js:366:7
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
>       at Immediate._onImmediate (/usr/lib/nodejs/mocha/lib/runner.js:334:5)
> 
>   3) define
>        should define a property on an array:
> 
>       AssertionError [ERR_ASSERTION]: 'bar' == 'baz'
>       + expected - actual
> 
>       -bar
>       +baz
> 
>       at Context.<anonymous> (test.js:72:12)
>       at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21)
>       at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
>       at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
>       at /usr/lib/nodejs/mocha/lib/runner.js:560:12
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
>       at /usr/lib/nodejs/mocha/lib/runner.js:366:7
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
>       at Immediate._onImmediate (/usr/lib/nodejs/mocha/lib/runner.js:334:5)
> 
>   4) define
>        should define a property on an error:
> 
>       AssertionError [ERR_ASSERTION]: 'bar' == 'baz'
>       + expected - actual
> 
>       -bar
>       +baz
> 
>       at Context.<anonymous> (test.js:88:12)
>       at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21)
>       at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
>       at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
>       at /usr/lib/nodejs/mocha/lib/runner.js:560:12
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
>       at /usr/lib/nodejs/mocha/lib/runner.js:366:7
>       at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
>       at Immediate._onImmediate (/usr/lib/nodejs/mocha/lib/runner.js:334:5)
> 
> make[1]: *** [debian/rules:9: override_dh_auto_test] Error 4

Found:
1)  you embedded only one outdated component (is-descriptor, others
    missing)
1a) you should not install them in usr/lib/nodejs/is-descriptor* since
    it conflicts with our node-is-descriptor* (2.0.0) but in
    /usr/lib/nodejs/node-define-property/node_modules/is-descriptor*
2)  *prefer to patch upstream source* to use our node-is-descriptor-*
    and report bug to upstream. At least report the bug and wait a few
    days for upstream response