[Pkg-javascript-devel] RFS: node-define-property 2.0.2+~1.0.2-1

[Xavier]

Le 30/01/2019 à 19:25, Paolo Greppi a écrit :
> Hi Xavier,
> 
> and thanks for the review ! see below
> 
> Paolo
> 
> Il 30/01/19 18:45, Xavier ha scritto:
>> Le 30/01/2019 à 18:11, Xavier a écrit :
>>> Le 30/01/2019 à 15:20, Paolo Greppi a écrit :
>>>> Hi, I have prepared an update to node-define-property.
>>>> ...
>>>
>>> Hello,
>>>
>>> I fixed some things. Anyway, build fails for now:
>>>
>>>   4 passing (28ms)
>>>   4 failing
>>>   ...
> 
> Silly me ! I had not pushed all my commits :blush:
> Now I have, after rebasing on top of yours, and they pass:
> https://salsa.debian.org/js-team/node-define-property/pipelines/34381
> 
>> Found:
>> 1)  you embedded only one outdated component (is-descriptor, others
>>     missing)
> 
> check
> 
>> 1a) you should not install them in usr/lib/nodejs/is-descriptor* since
>>     it conflicts with our node-is-descriptor* (2.0.0) but in
>>     /usr/lib/nodejs/node-define-property/node_modules/is-descriptor*
> 
> you're right ! done
> 
>> 2)  *prefer to patch upstream source* to use our node-is-descriptor-*
>>     and report bug to upstream. At least report the bug and wait a few
>>     days for upstream response
> 
> I have done that and been laughed at:
> https://github.com/jonschlinkert/define-property/issues/3
> 
> Paolo

I think in this case we should "uscan-ignore" components instead of "group"