[Pkg-javascript-devel] <DKIM> Re: node-acorn-dynamic-import_4.0.0-1_amd64.changes ACCEPTED into unstable

[Xavier]

Le 11/07/2019 à 08:32, Julien Puydt a écrit :
> Hi,
> 
> Le 10/07/2019 à 11:42, Pirate Praveen a écrit :
>>> Format: 1.8
>>> Date: Tue, 09 Jul 2019 18:34:17 +0200
>>> Source: node-acorn-dynamic-import
>>> Binary: node-acorn-dynamic-import
>>> Architecture: source all
>>> Version: 4.0.0-1
>>
>> This upload broke node-webpack and node-buble and that means a large number of packages now FTBFS.
> 
> Sigh... sorry. I did use apt-get rdepends and check the packages there
> build with my new package, but for some reason, I didn't see the
> problem... perhaps my config is broken. That would also explain why I
> also had to revert node-typescript which I also tested :-/
> 
>> I noticed it here https://ci.debian.net/packages/n/node-d3-random/unstable/amd64/
>>
>> I request everyone uploading major version updates to verify it is not breaking any existing packages.
> 
> It still slipped through...
> 
>> With scripts from ruby-team its very easy to do.
>>
>> https://wiki.debian.org/Packaging/ruby-team-meta-build
> 
> That's what I do by hand, but I'll have to recheck my sbuild config,
> since obviously my checks don't work.
> 
>> If it is breaking any reverse dependency, please file a bug and give some time for fixing the affected package before uploading to unstable. It is a good idea to use process of transition when uploading breaking changes.
> 
> I'll work on a new upload to clean the mess.
> 
> Sorry,
> 
> JP

node-buble upgrade needs:
 * acorn                : 5.5.3 => 6.2.0
 * acorn-dynamic-import : 3.0.0 => 4.0.0
 * acorn-jsx            : 4.1.1 => 5.0.1

So we will have to update:
 * first rollup to break acorn-dynamic-import link
 * second buble with an embed of 3 acorn modules
 * then acorn/acorn-dynamic-import
 * then when all is in testing, remove embedded components in buble

Am I right ?