[Pkg-javascript-devel] Bug#928645: RFI: replacement of touch module with fs

[Ritesh Raj Sarraf]

Package: node-lockfile
Version: 1.0.4
Severity: normal

Hi,

This is mostly about trying to determine the reason for the change.
I noticed that in patch `remove-touch.patch`, the requirement for `touch`
module is worked around by the `fs` module.

Is it because by the minor change you were able to avoid an additional
package dependency? Or is there any other reason, like `touch` being
buggy/unmaintained ?

I have a build failure with test `staleness-sync-test` in
tests/basic.js, which I'm encountering only on slow arm32 hardware.

Your change in the above patch looks good enough to me (and my test
failure is something I think to do with the slowness of the hardware),
but I still wanted to check if there is any known reason otherwise, for
you to go this route and deviate from upstream ?


Thanks,
Ritesh

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (900, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-5-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_USER
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled