[Pkg-javascript-devel] Bug#929654: Outdated node-unicode-property-value-aliases results in incomplete package rebuild

[Daniel Drake]

Package: node-unicode-12.0.0
Version: 0~20190414+gitbf518e99-2

node-unicode-data 0~20190414+gitbf518e99-2 was originally built
successfully and correctly under sid, and then the binaries were
imported to buster.

However, if you now try to rebuild node-unicode-data under pure
buster, you will get this error during the build process:

node scripts/generate-data.js
[16:03:24] Worker 2 is done!
[16:03:24] Worker 1 is done!
[16:03:24] Worker 4 → Unicode v12.0.0
Generating data for Unicode v12.0.0…
Parsing Unicode v12.0.0 categories…
[16:03:24] Worker 3 is done!
Parsing Unicode v12.0.0 `Script`…
Parsing Unicode v12.0.0 `Script_Extensions`…
Assertion failed: canonical name for Nand = undefined not present in
`scriptsMap`
/root/node-unicode-data-0~20190414+gitbf518e99/scripts/parse-script-extensions.js:62
                scriptsMap[canonicalName].add(codePoint);
                                          ^
TypeError: Cannot read property 'add' of undefined
    at /root/node-unicode-data-0~20190414+gitbf518e99/scripts/parse-script-extensions.js:62:31
    at Array.forEach (<anonymous>)
    at /root/node-unicode-data-0~20190414+gitbf518e99/scripts/parse-script-extensions.js:52:12
    at Array.forEach (<anonymous>)
    at Object.parseScriptExtensions
(/root/node-unicode-data-0~20190414+gitbf518e99/scripts/parse-script-extensions.js:26:8)
    at generateData
(/root/node-unicode-data-0~20190414+gitbf518e99/index.js:61:18)
    at complicatedWorkThatTakesTime
(/root/node-unicode-data-0~20190414+gitbf518e99/scripts/generate-data.js:31:3)
    at process.on
(/root/node-unicode-data-0~20190414+gitbf518e99/scripts/generate-data.js:74:3)
    at process.emit (events.js:194:15)
    at emit (internal/child_process.js:820:12)


The error is ignored, the build continues anyway and goes on to
produce a node-unicode-12.0.0 binary packages that is missing many
files.

If you then try and use this binary, the missing files will cause
other packages will fail to build such as acorn:
   Error: Cannot find module
'unicode-12.0.0/Binary_Property/ID_Start/code-points.js

This issue can be avoided by bringing
node-unicode-property-value-aliases version 3.4.0+ds-1 from sid into
buster too. This new version includes the missing mapping of the
'Nand' script that is mentioned in the error message.