[Pkg-javascript-devel] build node-i18next with webpack instead or rollup?

[Pirate Praveen]

On 2019, ഒക്‌ടോബർ 7 7:17:30 PM IST, Nicolas Mora <nicolas at babelouest.org> wrote:
>Hi,
>
>Le 19-10-07 à 04 h 02, Pirate Praveen a écrit :
>> 
>> See
>>
>https://salsa.debian.org/ruby-team/rails/blob/master/debian/patches/0002-disable-uglify-in-activestorage-rollup-config-js.patch
>> to pass system paths to rollup-plugin-node-resolve instead of copying
>> whole /usr/lib/nodejs.
>> 
>> Pass /usr/lib/nodejs and /usr/share/nodejs both.
>> 
>If I apply this change, I got a lot of errors like this:
>
>(!) Circular dependency:
>../../../usr/lib/nodejs/core-js/library/modules/_export.js ->
>../../../usr/lib/nodejs/core-js/library/modules/_hide.js ->
>../../../usr/lib/nodejs/core-js/library/modules/_object-dp.js ->
>../../../usr/lib/nodejs/babel-runtime/core-js/object/define-property.js
>-> ../../../usr/lib/nodejs/core-js/library/fn/object/define-property.js
>->
>../../../usr/lib/nodejs/core-js/library/modules/es6.object.define-property.js
>-> ../../../usr/lib/nodejs/core-js/library/modules/_export.js
>
>Aby idea how to fix it?

I have seen such warnings, though I'm not sure how serious it is. Did the build fail?

>> Also I think you have applied patches directly in master, we don't
>> follow that scheme in js-team. Please unapply patches from master or
>> otherwise quilt push -a was failing
>> 
>My mistake, bad habit, it's fixed in the next commit, thanks
>
>> You can use debian/nodejs/build instead of override_dh_auto_build.
>> 
>Done

I'll check it later.

>/Nicolas

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.