[Pkg-javascript-devel] Rollup do _not_ need migrating to terser from UglifyJS

[Pirate Praveen]

On Thu, Oct 10, 2019 at 18:50, Jonas Smedegaard <dr at jones.dk> wrote:
> Hi all,
> 
> It seems Rollup 0.56.3 (or some of its dependencies) had a bug causing
> it to generate a .map file causing UglifyJS (but not Terser) to fail.
> 
> This was discovered as part of bug#941601 against 
> leaflet-markercluster
> where I found the proposed switch of compressor too invasive and had a
> closer look at what was really going in.
> 
> The bug seems fixed now with Rollup 0.68.2-1.  Please tell if relevant
> to file it for further tracking.
> 

Since rollup 0.68.2 is already in unstable, I think we are good.

> Reason I post here is that as part of the Rollup work, Pirate Praveen
> provided a patch for Leaflet.Markercluster which involved switching 
> from
> UglifyJS to Terser, and I want to emphasize that such change is _not_
> necessary and I recommend switching back if similar tricks was done 
> for
> other libraries.

> 
I have seen some of the projects I maintain (for example d3, webpack 
and rollup itself) switching to terser from uglifyjs. So just wanted to 
see if the bug was in uglifyjs. My personal opinion is to transition 
all packages using uglifyjs to terser as maintaining two uglifiers is 
extra work. For me the goal is to generate a minified file and I don't 
really care strongly about which uglifier I use as long it works well, 
so I don't consider switching to terser as an invasive change. But 
since you are doing the actual work and you don't mind maintaining two 
close enough packages, your opinion has more weight.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20191011/abcd8b51/attachment.html>