[Pkg-javascript-devel] [review(rollup transitions)] node-tippex

[Xavier]

Le 12/10/2019 à 08:41, Pirate Praveen a écrit :
> 
> 
> On Sat, Oct 12, 2019 at 02:11, Nilesh Patra <npatra974 at gmail.com> wrote:
>> Hi,
>> node-tippex is one of the many packages that are required to be fixed
>> in rollup transition to 0.68.2 . The changes have been pushed at
>> https://salsa.debian.org/js-team/node-tippex .
>> It would be great if someone could review the package.
>>
> 
> It seems you messed up the changelog. 3.0.0+ds-3 is already uploaded to
> unstable. You should not change existing changelog entries (except for
> formating changes or somehting you missed). You should add a new entry
> and version.
> 
>> Thanks and regards
>> Nilesh

I fixed changelog and added a dependency to "rollup << 1.0.0~": another
update is required because of this error (acorn-jsx is installed and
node can load acorn-jsx/inject):

Found debian/nodejs/./build
        cd ./. && sh -e debian/nodejs/./build
[!] Error: Cannot find module 'acorn-jsx/inject'
Error: Cannot find module 'acorn-jsx/inject'
    at Function.Module._resolveFilename
(internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/usr/lib/nodejs/buble/dist/buble.cjs.js:8:32)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Object.require.extensions..js
(/usr/share/nodejs/rollup/bin/src/run/loadConfigFile.js:43:17)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)

Uploaded anyway to unblock node-rollup 0.67