[Pkg-javascript-devel] Bug#939391: node-elliptic: test failure with new node-bn.js

[Gianfranco Costamagna]

Source: node-elliptic
Version: 6.5.0~dfsg-1
Tags: patch
Severity: serious
Forwarded: https://github.com/indutny/elliptic/pull/193

Hello, looks like the testsuite now fails because "hello" is not an hex string...

the following patch seems to fix it (I'm not sure if there is a better approach to this, just the new node-bn.js is more picky about bad characters

thanks for having a look,

Gianfranco


Description: Sign accepts an hex string, non an ascii one
Forwarded: https://github.com/indutny/elliptic/pull/193
--- node-elliptic-6.5.0~dfsg.orig/test/ecdsa-test.js
+++ node-elliptic-6.5.0~dfsg/test/ecdsa-test.js
@@ -61,7 +61,7 @@ describe('ECDSA', function() {

       it('should have `signature.s <= keys.ec.nh`', function() {
         // key.sign(msg, options)
-        var sign = keys.sign('hello', { canonical: true });
+        var sign = keys.sign(msg, { canonical: true });
         assert(sign.s.cmp(keys.ec.nh) <= 0);
       });