[Pkg-javascript-devel] Bug#956385: node-request: uses internet access during build

[Gianfranco Costamagna]

Source: node-request
Version: 2.88.1-3
Severity: serious

Hello,
looks like the dh_auto_test process is trying to go on internet, and this is forbidden by policy.
I found this problem on Ubuntu builders, where the internet access is more strictly forbidden.


[...]
not ok 549 should be equal
  ---
    operator: equal
    expected: false
    actual:   true
    at: Request._callback (/<<PKGBUILDDIR>>/tests/test-localAddress.js:11:7)
    stack: |-
      Error: should be equal
          at Test.assert [as _assert] (/usr/lib/nodejs/tape/lib/test.js:235:54)
          at Test.bound [as _assert] (/usr/lib/nodejs/tape/lib/test.js:87:32)
          at Test.equal (/usr/lib/nodejs/tape/lib/test.js:395:10)
          at Test.bound [as equal] (/usr/lib/nodejs/tape/lib/test.js:87:32)
          at Request._callback (/<<PKGBUILDDIR>>/tests/test-localAddress.js:11:7)
          at self.callback (/<<PKGBUILDDIR>>/request.js:185:22)
          at Request.emit (events.js:198:13)
          at Request.onRequestError (/<<PKGBUILDDIR>>/request.js:881:8)
          at ClientRequest.emit (events.js:198:13)
          at Socket.socketErrorListener (_http_client.js:401:9)
          at Socket.emit (events.js:198:13)
          at emitErrorNT (internal/streams/destroy.js:91:8)
          at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
          at process._tickCallback (internal/process/next_tick.js:63:19)
  ...
ok 550 should be equal
# bind to local address
ok 551 should not be equal
ok 552 should be equal
# bind to local address on redirect
not ok 553 should be equal
  ---
    operator: equal
    expected: |-
      null
    actual: |-
      { [Error: getaddrinfo ENOTFOUND google.com google.com:80] errno: 'ENOTFOUND', code: 'ENOTFOUND', syscall: 'getaddrinfo', hostname: 'google.com', host: 'google.com', port: 80 }
    at: Request._callback (/<<PKGBUILDDIR>>/tests/test-localAddress.js:45:7)
    stack: |-
      Error: getaddrinfo ENOTFOUND google.com google.com:80
          at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:56:26)
  ...
/<<PKGBUILDDIR>>/tests/test-localAddress.js:46
    t.equal(res.request.localAddress, localIPS[0])
                ^

TypeError: Cannot read property 'request' of undefined
    at Request._callback (/<<PKGBUILDDIR>>/tests/test-localAddress.js:46:17)
    at self.callback (/<<PKGBUILDDIR>>/request.js:185:22)
    at Request.emit (events.js:198:13)
    at Request.onRequestError (/<<PKGBUILDDIR>>/request.js:881:8)
    at ClientRequest.emit (events.js:198:13)
    at Socket.socketErrorListener (_http_client.js:401:9)
    at Socket.emit (events.js:198:13)
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at process._tickCallback (internal/process/next_tick.js:63:19)
dh_auto_test: error: /bin/sh -e debian/tests/pkg-js/test returned exit code 1
make: *** [debian/rules:5: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2