[Pkg-javascript-devel] select2.js_4.0.13+dfsg-1_amd64.changes REJECTED

[merkys at debian.org]

Hi Sean,

Many thanks for the review.

On 2020-04-16 02:00, Sean Whitton wrote:
> src/scss/mixins/_gradients.scss has code from another project with
> different copyright holders.

Thanks for noticing this – I will add an entry in debian/copyright
regarding this file.

> It looks like tests/unit-jq*.html depend on the file
> vendor/qunit-1.23.1.css -- can the tests be run successfully without
> this file?  If not, we will have to remove more files, because Debian
> main is meant to be self-contained.

Tests are not run for this package due to not yet packaged dependencies.
Thus files tests/unit-jq*.html are not used at all for now. However, as
these files are part of the upstream tarball and are covered by the same
top-level license, I would prefer to keep them until test dependencies
get packaged. When this happens, these files should be patched to use
Debian qunit.css instead of excluded vendor one. Would this be acceptable?

> I notice this package keeps being removed and reuploaded to NEW.
> Perhaps it would be better to keep it in the archive for longer before
> removal, if it again loses its reverse deps, to save effort.

I completely agree.

Best wishes,
Andrius