[Pkg-javascript-devel] Bug#960120: node-yarnpkg: I found an older commit that still builds

[Paolo Greppi]

Il 15/08/20 14:00, Pirate Praveen ha scritto:
>> With this build:
>> https://salsa.debian.org/js-team/node-yarnpkg/-/jobs/915568#L2420
> 
>> I get a different error while building:
>> [17:58:12] Starting 'build'...
>> 2420[17:58:13] Error: [BABEL] /builds/js-team/node-yarnpkg/debian/output/node-yarnpkg-1.22.4/src/api.js: Cannot find module
>> 'babel-plugin-transform-strict-mode'
> 
>> ?
> 
> With sbuild, I can reproduce the error. But on a sid schroot, dpkg-buildpackage works. May be I have some things locally installed.
> 
> If you go back to commit 3f1ab4d62789670ee39648eb35078ce244ba2d09 it is building fine. We need to analyze the commits that came after this I think.

The autopkgtest failure you mention in your message to the BTS of May 17th is a side effect.
The root cause is that the webpack build itself is broken, but the error message ("Unhandled rejection TypeError: fileDependencies.map is not a function") is not really helpful.
(I had pointed that out here already: https://bugs.debian.org/958780#39)

I have rebased my last commit (that patches scripts/build-webpack.js so that it prints the actual errors) on top of 3f1ab4d6, in the wip/paolog/babel7 branch.
In the log a bunch of new ERRORS appear:

    ERROR in ./src/errors.js
    Module not found: Error: Can't resolve '@babel/runtime/helpers/assertThisInitialized' in '/builds/js-team/node-yarnpkg/debian/output/node-yarnpkg-1.22.4/src'
    @ ./src/errors.js 12:53-108
    @ ./src/cli/index.js
    ...
    ERROR in ./src/config.js
    Module not found: Error: Can't resolve '@babel/runtime/helpers/asyncToGenerator' in '/builds/js-team/node-yarnpkg/debian/output/node-yarnpkg-1.22.4/src'
    @ ./src/config.js 17:48-98
    @ ./src/cli/index.js
    ...
    ERROR in ./src/errors.js
    Module not found: Error: Can't resolve '@babel/runtime/helpers/classCallCheck' in '/builds/js-team/node-yarnpkg/debian/output/node-yarnpkg-1.22.4/src'
    @ ./src/errors.js 10:46-94
    @ ./src/cli/index.js
    ...

for the full list see the salsa CI run: https://salsa.debian.org/js-team/node-yarnpkg/-/jobs/937269#L2529

I think we've been too eager to upgrade to babel 7, while upstream does not really care (see https://github.com/yarnpkg/yarn/issues/8083)
Also our patches should be easy to forward.

Unfortunately I am not able to help with troubleshooting this babel.

Paolo