[Pkg-javascript-devel] Bug#977535: Bug#977535: Bug#977535: pkg-js-tools should create node_modules symlink in autopkgtest

[Xavier]

Le 16/12/2020 à 12:05, Xavier a écrit :
> Le 16/12/2020 à 11:56, Pirate Praveen a écrit :
>> Control: clone -1 -2
>> Control: reassign -2 pkg-js-tools
>> Control: retitle -2 use cp -rL for extcopies (needed for symlinks)
>> Control: reassign node-d3-geo,pkg-js-tools,node-tape
>>
>> On Wed, Dec 16, 2020 at 8:27 am, Xavier <yadd at debian.org> wrote:
>>> Hi,
>>>
>>> when using tsc, if /usr/share/nodejs/foo is linked in
>>> debian/nodejs/extlinks and requires another file linked in
>>> debian/nodejs/extlinks, this fails because tsc search a "node_modules"
>>> directory starting from /usr/share/nodejs/foo (see typescript bug
>>> https://github.com/microsoft/TypeScript/issues/33661).
>>>
>>> To avoid this, use debian/nodejs/extcopies.
>>
>> No, that did not fix the autopkgtest. tape needs @babel/register in
>> node_modules. The problem is not symlinks vs copies, but during
>> autopkgtest, @babel/register is not found by tape. Symbolic links
>> (extlinks) is enough in this case as tests work during build with
>> symbolic links.
>>
>> So extlinks or extcopies should be respected for autopkgtests also I
>> think. Or we need to fix node-tape to look in global paths. We can
>> reassign to correct package once we decide where it should be fixed.
>>
>> And for extcopies, I am cloning this as another bug. cp -r will create
>> broken symbolic links as many of our node packages include symbolic
>> links, for example node-font-awesome (provided by fonts-font-awesome) or
>> node-terser. So we should use cp -rL to dereference symbolic links.
> 
> pkg-js-autopkgtest already reads debian/nodejs/extlinks (but not
> debian/nodejs/extcopies, this is the bug)

Could you try pkg-js-autopkgtest 0.9.55 (experimental + salsa) ?