[Pkg-javascript-devel] Bug#977685: Bug#977685: node-jest: build routines are too brittle: build failures go undetected

[Jonas Smedegaard]

Quoting Xavier (2020-12-18 22:59:06)
> Le 18/12/2020 à 22:28, Jonas Smedegaard a écrit :
> > Source: node-jest
> > Version: 26.6.3+repack+~cs61.38.31-3
> > Severity: serious
> >
> > By accident I noticed that a release of node-jest with only changes to
> > package relations changed size from 8.5 megabytes to 500 kilobytes.
> > 
> > A closer examination of build logs seems to indicate failures to compile
> > TypeScript code into JavaScript.
> > 
> > Build logs are here: https://buildd.debian.org/status/logs.php?pkg=node-jest&arch=all
> > 
> >   wget 'https://buildd.debian.org/status/fetch.php?pkg=node-jest&arch=all&ver=26.6.3%2Brepack%2B%7Ecs61.38.31-2&stamp=1607423417&raw=0'
> >   wget 'https://buildd.debian.org/status/fetch.php?pkg=node-jest&arch=all&ver=26.6.3%2Brepack%2B%7Ecs61.38.31-3&stamp=1608313404&raw=0'
> >   git diff --no-index fetch.php*
> > 
> > Detail from log comparison which seems important:
> > 
> > -dh_auto_install: warning: ### Missing char-regex/src, skipping
> > -
> > -dh_auto_install: warning: ### Missing char-regex/tsconfig.json, skipping
> > -
> > -dh_auto_install: warning: ### Missing char-regex/tsconfig.tsbuildinfo, skipping
> 
> These message are false-positive bad warning when using default
> .npmignore. I'll remove them in pkg-js-tools.
> 
> The difference comes from new pkg-js-tools feature: it reads now
> .npmignore, then /usr/share/nodejs/jest-each/assets/ is now removed. I
> didn't see that this directory contains 4 very big .gif!

GIFs! I even saw those, but didn't expect them to matter so much.


> So closing this bug, this is not a bug but an improvement of pkg-js-tools!
> 
> Thanks to have looked at this.

Thanks for solving it so quickly!

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20201218/0bba2e90/attachment.sig>