[Pkg-javascript-devel] Bug#977744: pkg-js-tools: debian/nodejs/extlinks parsing should be strict

[Jonas Smedegaard]

Package: pkg-js-tools
Version: 0.9.58
Severity: important

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

pkg-js-tools documents that debian/nodejs/extlinks "lists installed node
modules that should be linked into `node_modules` directory.

But apparently it silently skips entries not installed.

That is problematic, because it might lead to silently building
differently than intended, or lead to build failures difficult to debug.

I cannot see a good reason for parsing of debian/nodejs/extlinks to be
relaxed - seems to me that it should be strict - i.e. fail if it fails
to locate an entry at either /usr/share or /usr/lib (in that order).

On a related note, I think documentation should explicitly mention that
it will link from either /usr/share or /usr/lib in that order - because
that is what it does, right?  I am just blindly assuming that, which is
bad...


 - Jonas

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAl/ehSUACgkQLHwxRsGg
ASFeTg//b8tfvE1l6BljPK0dUXrrdGHUcH0K0XSR6WikstyTpliZ2NupenufuOmM
0rSok22PZb1WN2TfJaHdISCUQGB/g6z9Kqsdj0/yaDGc9QTQiHykNyPv4CwSO3Gu
IhLGxn50fX3JewV32qZkXxRSCbjjWaewUMRK3bKVh+flkrEuzaosIjQbsrTTTvVg
sABDKAznWvK3LJApkB0GUtp5KqggRU29i5BKD+wMiqSoZpaGY4crnqJarjPc9sUy
ZFQs47eQqJQid+cIqU8tvbXMYVQ3RiKVucNodn9MXjQT4VpKQeQ7yyNlJBCcMZRA
b9ep1AAo1Dvy6fi7lQk2aZRg99C2ZQI4e8Nz6FHTFTGe7p7JMSzFt64OWgWdBrEr
JzTo5i20ogyN1CKo5C5NVRS2vlZZ9YxLWGOhJar1993tvg+VRWG+OVJbHrYNuCl9
lexPpK5VrzxGs26QeC05Eolr65sLbZBbiu3pCRRlThZ2E4jVXGgbAxDKTXuATfvC
WNealbwzEz7JtWW0f+Ua5TsRvSEO5+Vw3niXDsdk2rsNLd5J3RyYDZULpRTHj107
Ck6RS0DzbrBkFFFu+VVkERu+UcuHZm5NuwJQPDEknqEDBsibyL5o0T3rf+arQUpw
9xedYPQ5gXONNDmcPAJ0IrFNFdkYN7N3Rsr0Xweupa6Ytj/aS+o=
=LJzw
-----END PGP SIGNATURE-----