[Pkg-javascript-devel] which recently changed dependency broke node-terser? See bug#950666

[Jonas Smedegaard]

Quoting Xavier (2020-02-05 05:56:27)
> Le 04/02/2020 à 21:48, Jonas Smedegaard a écrit :
> > Quoting Xavier (2020-02-04 21:32:17)
> >> Le 04/02/2020 à 21:02, Xavier a écrit :
> >>> Le 04/02/2020 à 17:52, Xavier a écrit :
> >>>> Le 4 février 2020 17:06:44 GMT+01:00, Jonas Smedegaard 
> >>>> <dr at jones.dk> a écrit :
> >>>>> node-terser has not been changed for 3 months.
> >>>>>
> >>>>> Today it was reported broken: https://bugs.debian.org/950666
> >>>>>
> >>>>> Smells like the thing broken is some recent change in its 
> >>>>> dependency chain rather than the node-terser package itself.
> >>>>>
> >>>>> Anyone recognize a recently uploaded module among the ones 
> >>>>> below?
> >>>>>
> >>>>> Mocha, perhaps?
> >>>>>
> >>>>> @Xavier, you mention in changelog that mocha had "successful 
> >>>>> tests" - did those tests include rebuilding node-terser?
> >>>>
> >>>> I didn't test all rebuild but fixed all autopkgtest failures due 
> >>>> to mocha changes (all easy to fix btw). I'll take a look at 
> >>>> terser tomorrow morning.
> > 
> >>> build fails also, this seems not related to mocha:
> > 
> > I agree that the cause of the problem seems to be unrelated to 
> > mocha: I wrongly assumed that the issue was but but apparently it 
> > began in December: 
> > https://tests.reproducible-builds.org/debian/history/node-terser.html
> > 
> > That said, I am puzzled by the build failure you are presenting here 
> > - my build failures and those at tests.reproducible-builds.org are 
> > unrelated to help2man - can you please share more information about 
> > how you ensure that the build environment is clean (do you use 
> > pbuilder or some other method?) and ideally point to a full build 
> > log (please reference only, not attach: it is rather big).
> > 
> > 
> > Thanks for helping look into this,
> 
> I built simply using sbuild and a minimal unstable schroot. Here are 
> the logs

I am not familiar with sbuild, but seems the option "--no-clean-source" 
makes it less interesting (and I guess that also relates to the lack of 
listing which exact versions of all non-core packages was installed).

For the node-terser issue specifically, it does not really matter (I 
agree that mocha is unlikely causing it), but if unclean builds is the 
level of testing you generally do, then I strongly urge you to do 
better: Test in a clean chroot!

Thanks anyway,

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20200205/22f642c1/attachment.sig>