[Pkg-javascript-devel] Bug#950666: Bug#950666: node-terser FTBFS: test failures

[Nilesh Patra]

Hi

On Wed, 05 Feb 2020 13:41:37 +0100 Jonas Smedegaard <jonas at jones.dk> wrote:

> control: tags -1 +confirmed
> control: retitle -1 node-terser FTBFS: fails 7 tests in "bin/uglifyjs"
and "bin/uglifyjs with input file globs"
>
> Quoting Adrian Bunk (2020-02-04 16:29:34)
> > Source: node-terser
> > Version: 4.1.2-4
> > Severity: serious
> > Tags: ftbfs
> >
> >
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/node-terser.html
> >
> > ...
> > 231 passing (47s)
> > 4 pending
> > 7 failing
> >
> > 1) bin/uglifyjs (2)
> > Should dump AST as JSON:
> > Uncaught Command failed: "/usr/bin/node" bin/uglifyjs
test/input/global_defs/simple.js -mco ast
> > ERROR: ENOENT: no such file or directory, open 'ast'
> > at Object.openSync (fs.js:443:3)
> > at Object.readFileSync (fs.js:343:35)
> > at read_file (/build/1st/node-terser-4.1.2/bin/uglifyjs:353:19)
> > at /build/1st/node-terser-4.1.2/bin/uglifyjs:176:37
> > at Array.forEach (<anonymous>)
> > at Object.<anonymous> (/build/1st/node-terser-4.1.2/bin/uglifyjs:175:28)
> > at Module._compile (internal/modules/cjs/loader.js:778:30)
> > at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
> > at Module.load (internal/modules/cjs/loader.js:653:32)
> > at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
> >
> > Error: Command failed: "/usr/bin/node" bin/uglifyjs
test/input/global_defs/simple.js -mco ast
> > ERROR: ENOENT: no such file or directory, open 'ast'
> > at Object.openSync (fs.js:443:3)
> > at Object.readFileSync (fs.js:343:35)
> > at read_file (bin/uglifyjs:353:19)
> > at /build/1st/node-terser-4.1.2/bin/uglifyjs:176:37
> > at Array.forEach (<anonymous>)
> > at Object.<anonymous> (bin/uglifyjs:175:28)
> > at Module._compile (internal/modules/cjs/loader.js:778:30)
> > at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
> > at Module.load (internal/modules/cjs/loader.js:653:32)
> > at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
> >
> > at ChildProcess.exithandler (child_process.js:294:12)
> > at maybeClose (internal/child_process.js:982:16)
> > at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)
> > ...
>
> Thanks for reporting!
>
> Tag as confirmed (corresponds with local cowbuilder build).
>
> Update bug title to disambiguate from similar but possibly different
> issue discussed in JavaScript team (not yet formally reported).

I have fixed it to build along with passing autopkgtests and there are
no lintian warnings + errors as well.
Also fixed the other bug #950733 associated with the package.(I tried
emulating your changes in node-uglify here).
I have pushed the changes to my local fork here[1].
Needs review and sponsorship.

[1]: https://salsa.debian.org/gi-boi-guest/node-terser/

Thanks and regards,
Nilesh

>
> - Jonas
>
> --
> * Jonas Smedegaard - idealist & Internet-arkitekt


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20200219/a6e162a6/attachment.sig>