[Pkg-javascript-devel] gulp 4 migration

[Pirate Praveen]

On ചൊ, Jan 14, 2020 at 19:22, Paolo Greppi <paolo.greppi at libpf.com> 
wrote:
> Il 14/01/20 18:59, Pirate Praveen ha scritto:
>>  ...
>>  Forgot to attach the log I guess, also pristine-tar branch is 
>> missing the latest version.
> 
> OK attached
> 
Thanks.

> Nope pristine-tar has node-yarnpkg_1.2.1.orig*:
> https://salsa.debian.org/js-team/node-yarnpkg/tree/pristine-tar
> 
>>  I was able to build from experimental branch and got this error. 
>> This is probably a bug in gulp itself.
> 
> experimental branch differs from master only for debian/gbp.conf and 
> debian/gitlab-ci.yml (besides the recent commits from Xavier)
> 

See if 
https://salsa.debian.org/ruby-team/meta/blob/master/build-and-upload#L315 
is finding the correct file.

>>  gulp build
>>  [17:56:05] Local gulp not found in /<<PKGBUILDDIR>>
>>  [17:56:05] Try running: npm install gulp
>>  [17:56:05] Using globally installed gulp
>>  internal/modules/cjs/loader.js:638
>>     throw err;
>>     ^
>> 
>>  Error: Cannot find module 'get-value'
>>     at Function.Module._resolveFilename 
>> (internal/modules/cjs/loader.js:636:15)
>>     at Function.Module._load (internal/modules/cjs/loader.js:562:25)
>>     at Module.require (internal/modules/cjs/loader.js:692:17)
>>     at require (internal/modules/cjs/helpers.js:25:18)
>>     at Object.<anonymous> 
>> (/usr/share/nodejs/gulp/node_modules/array-sort/index.js:12:11)
>>     at Module._compile (internal/modules/cjs/loader.js:778:30)
>>     at Object.Module._extensions..js 
>> (internal/modules/cjs/loader.js:789:10)
>>     at Module.load (internal/modules/cjs/loader.js:653:32)
>>     at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
>>     at Function.Module._load (internal/modules/cjs/loader.js:585:3)
>>  make[1]: *** [debian/rules:26: override_dh_auto_build] Error 1
>>  make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> 
> weird ! it built 3 weeks ago on salsa CI using gulp 4.0.2-4 
> (experimental):
> https://salsa.debian.org/js-team/node-yarnpkg/-/jobs/470197
> 
> get-value is required by array-sort which is a dependency of gulp-cli 
> 2:
> https://github.com/gulpjs/gulp-cli/blob/master/package.json#L36
> 
> Not sure of what is going on

node-get-value should be in Depends for gulp I think.