[Pkg-javascript-devel] gulp 4 migration

[Pirate Praveen]

On ബു, Jan 15, 2020 at 20:03, Paolo Greppi <paolo.greppi at libpf.com> 
wrote:
> Il 14/01/20 20:43, Pirate Praveen ha scritto:
>>>>>   I was able to build from experimental branch and got this 
>>>>> error. This is probably a bug in gulp itself.
>>  ...
>>  node-get-value should be in Depends for gulp I think.
>> 
> 
> I got meta/build to build it too (see below) with the same error.
> For that I filed a bug against gulp: https://bugs.debian.org/948994
> 
>>>  See if 
>>> https://salsa.debian.org/ruby-team/meta/blob/master/build-and-upload#L315 
>>> is finding the correct file.
>> 
>>  Strangely, it works if I set $PATH to the repo and call `build` but 
>> does not if I give direct path to the script like 
>> `../../ruby-team/meta/build`.
> 
> Yes, meta/build works if I launch the build executable with full path:
> 
> /root/meta/build
> 
> or as you did setting the PATH:
> 
> export PATH=/root/meta:$PATH
> build
> 
> in both cases, the SBUILD_CONFIG contains the full path:
> SBUILD_CONFIG = /root/meta/sbuild_experimental.conf
> 
> if I launch it with a relative path:
> 
> ../../meta/build
> 
> the SBUILD_CONFIG also has the relative path:
> SBUILD_CONFIG = ../../meta/sbuild_experimental.conf
> 
> and it somehow fails to add the experimental repo.
> 
> I propose to amend the meta/build-and-setup script to use realpath 
> before dirname as in this MR:
> https://salsa.debian.org/ruby-team/meta/merge_requests/8
> 

Thanks!

> Finally there is no way to create issues in the 
> https://salsa.debian.org/ruby-team/meta repo, what is the preferred 
> way to provide feedback ?

MRs or mail to debian-ruby at l.d.o or #debian-ruby on irc. MRs will be 
the best option.

> For example shellcheck returns a great number of warnings on that 
> script, I suggest fixing them.
> 

MRs will be welcome here :)
> Paolo
> 
> 
> 
> --
> Pkg-javascript-devel mailing list
> Pkg-javascript-devel at alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel