[Pkg-javascript-devel] [RFS] science.js

[Nilesh Patra]

On Wed, 22 Jan 2020 at 01:04, Xavier <yadd at debian.org> wrote:

> Le 21/01/2020 à 20:23, Xavier a écrit :
> > Le 21/01/2020 à 19:18, Nilesh Patra a écrit :
> >>
> >>
> >> On Tue, 21 Jan 2020 at 23:11, Xavier <x.guimard at free.fr
> >> <mailto:x.guimard at free.fr>> wrote:
> >>
> >>     Le 21/01/2020 à 16:08, Nilesh Patra a écrit :
> >>     >
> >>     >     Hi,
> >>     >
> >>     >     please regenerate minified files (exclude + repack): launch
> >>     make in
> >>     >     subdirectories
> >>     >
> >>     >
> >>     > Did the changes as asked. Could you review now?
> >>     > Thanks!
> >>
> >>     You miss to exclude also lib/d3/*.min.js
> >>
> >>
> >> Right. However, lib's Makefile uses certain files from src/ directory
> >> that aren't present, and there is no rule to do that, either in any of
> >> the Makefiles. (For example: src/core/date.js, src/core/zip.js etc)
> >> What would be the best to do in this case? I was thinking of keeping the
> >> minified files, as is and dropping the Makefile(inside lib/d3/), file an
> >> issue upstream.
> >> Do you think it is the right thing to do, or should something else be
> >> done instead? (Need your guidance here)
> >
> > Then keep lib/d3*.js without lib/d3*.min.js
>
>

> And generate them using uglifyjs
>
Nice! :)

Done, and pushed to my local fork. Please Review, if it looks OK.
Thanks!
Nilesh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20200122/ee13c9b6/attachment.html>