[Pkg-javascript-devel] [RFS] node-string-decoder

[Xavier]

Le 22/01/2020 à 13:35, Nilesh Patra a écrit :
> Hi, 
> I have fixed node-string-decoder to build with Node.js >= 12. It builds
> fine in a clean chroot. I have pushed my changes here[1]. 
> Needs Review and sponsorship.
> 
> [1]: https://salsa.debian.org/gi-boi-guest/node-string-decoder
> 
> Thanks and regards
> Nilesh

Hi,

1 - remove debian/install (pkg-js-tools does the job in this case)
2 - update homepage, source and debian/watch (duck reports that git repo
    moved to https://github.com/nodejs/string_decoder)
3 - launch "cme fix dpkg" to remove unneeded version constraints from
    (build) dependencies"
4 - ^ replaces also debhelper≥12 by debhelper-compa=12 and drom
    debian/compat
5 - Update debian/source/lintian-overrides with lintian "pedantic" false
    positives:
 source: source-contains-prebuilt-javascript-object
test/common/countdown.js line length is 564 characters (>512)
 source: source-contains-prebuilt-javascript-object test/common/dns.js
line length is 664 characters (>512)
 source: source-contains-prebuilt-javascript-object
test/common/duplexpair.js line length is 494 characters (>256)
 source: very-long-line-length-in-source-file test/common/countdown.js
line length is 564 characters (>512)
 source: very-long-line-length-in-source-file test/common/dns.js line
length is 664 characters (>512)


Tools used for this review: cme, lintian (level: pedantic), duck