[Pkg-javascript-devel] Bug#949580: Exclude Makefile from auto install if not explicitely set in debian/nodejs/files

Xavier yadd at debian.org
Wed Jan 22 13:21:50 GMT 2020


Control: tags -1 + confirmed

Le 22/01/2020 à 12:03, Chris Lamb a écrit :
> Source: node-ws
> Version: 7.2.1-2
> Severity: wishlist
> Tags: patch
> User: reproducible-builds at lists.alioth.debian.org
> Usertags: buildpath
> X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org
> 
> Hi,
> 
> Whilst working on the Reproducible Builds effort [0] we noticed that
> node-ws could not be built reproducibly.
> 
> This is because it ships a bunch of build artifacts under ".deps"
> directories under /usr/lib as well as some Makefile scripts, both of
> which contain the absolute build dir.
> 
> A patch attached that simply ensures they do not end up in the binary
> package, but this may not be the right or cleanest solution.
> 
>  [0] https://reproducible-builds.org/
> 
> Regards,

pkg-js-tools auto install should also exclude .deps directories and
bindings.gyp (arch-dep packages). @pkg-js-team: agree with this ?


Attached example shows the problem with node-ws
-------------- next part --------------
node-ws-dbgsym_7.2.1-2_amd64.deb
--------------------------------
 new Debian package, version 2.0.
 size 8528 bytes: control archive=640 bytes.
     414 octets,    12 lignes      control              
     296 octets,     3 lignes      md5sums              
 Package: node-ws-dbgsym
 Source: node-ws
 Version: 7.2.1-2
 Auto-Built-Package: debug-symbols
 Architecture: amd64
 Maintainer: Debian Javascript Maintainers <pkg-javascript-devel at lists.alioth.debian.org>
 Installed-Size: 31
 Depends: node-ws (= 7.2.1-2)
 Section: debug
 Priority: optional
 Description: debug symbols for node-ws
 Build-Ids: ad39c2c0214a75a6e395bdc41625b77b112562b9 b9b2dc7f3806d213d6832f95f5b08b1291e1f18f
drwxr-xr-x root/root         0 2020-01-21 18:56 ./
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/debug/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/debug/.build-id/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/debug/.build-id/ad/
-rw-r--r-- root/root      7128 2020-01-21 18:56 ./usr/lib/debug/.build-id/ad/39c2c0214a75a6e395bdc41625b77b112562b9.debug
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/debug/.build-id/b9/
-rw-r--r-- root/root      8136 2020-01-21 18:56 ./usr/lib/debug/.build-id/b9/b2dc7f3806d213d6832f95f5b08b1291e1f18f.debug
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/debug/.dwz/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/debug/.dwz/x86_64-linux-gnu/
-rw-r--r-- root/root      2176 2020-01-21 18:56 ./usr/lib/debug/.dwz/x86_64-linux-gnu/node-ws.debug
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/share/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/share/doc/
lrwxrwxrwx root/root         0 2020-01-21 18:56 ./usr/share/doc/node-ws-dbgsym -> node-ws

node-ws_7.2.1-2_amd64.deb
-------------------------
 new Debian package, version 2.0.
 size 65900 bytes: control archive=2656 bytes.
     844 octets,    20 lignes      control              
    7403 octets,    70 lignes      md5sums              
 Package: node-ws
 Version: 7.2.1-2
 Architecture: amd64
 Maintainer: Debian Javascript Maintainers <pkg-javascript-devel at lists.alioth.debian.org>
 Installed-Size: 385
 Depends: libc6 (>= 2.4), libnode64, nodejs, node-commander, node-read, node-tinycolor
 Section: javascript
 Priority: optional
 Homepage: https://github.com/websockets/ws
 Description: RFC-6455 WebSocket implementation module for Node.js
  ws is a simple to use websocket implementation, up-to-date against RFC-6455,
  and probably the fastest WebSocket library for Node.js.
  .
  Passes the quite extensive Autobahn test suite. See
  http://einaros.github.com/ws for the full reports.
  .
  It also provides wscat, a command-line tool which can either act
  as a server or a client, and is useful for debugging websocket services.
  .
  Node.js is an event-based server-side javascript engine.
drwxr-xr-x root/root         0 2020-01-21 18:56 ./
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/bin/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/
-rw-r--r-- root/root       175 2019-12-14 10:11 ./usr/lib/x86_64-linux-gnu/nodejs/ws/browser.js
-rw-r--r-- root/root       296 2019-12-14 10:11 ./usr/lib/x86_64-linux-gnu/nodejs/ws/index.js
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/lib/
-rw-r--r-- root/root      3389 2019-12-14 10:11 ./usr/lib/x86_64-linux-gnu/nodejs/ws/lib/buffer-util.js
-rw-r--r-- root/root       268 2019-12-14 10:11 ./usr/lib/x86_64-linux-gnu/nodejs/ws/lib/constants.js
-rw-r--r-- root/root      3937 2019-12-14 10:11 ./usr/lib/x86_64-linux-gnu/nodejs/ws/lib/event-target.js
-rw-r--r-- root/root      6883 2019-12-14 10:11 ./usr/lib/x86_64-linux-gnu/nodejs/ws/lib/extension.js
-rw-r--r-- root/root       981 2019-12-14 10:11 ./usr/lib/x86_64-linux-gnu/nodejs/ws/lib/limiter.js
-rw-r--r-- root/root     14239 2019-12-14 10:11 ./usr/lib/x86_64-linux-gnu/nodejs/ws/lib/permessage-deflate.js
-rw-r--r-- root/root     11968 2019-12-14 10:11 ./usr/lib/x86_64-linux-gnu/nodejs/ws/lib/receiver.js
-rw-r--r-- root/root      9523 2019-12-14 10:11 ./usr/lib/x86_64-linux-gnu/nodejs/ws/lib/sender.js
-rw-r--r-- root/root      3410 2019-12-14 10:11 ./usr/lib/x86_64-linux-gnu/nodejs/ws/lib/stream.js
-rw-r--r-- root/root       695 2019-12-14 10:11 ./usr/lib/x86_64-linux-gnu/nodejs/ws/lib/validation.js
-rw-r--r-- root/root     11460 2019-12-14 10:11 ./usr/lib/x86_64-linux-gnu/nodejs/ws/lib/websocket-server.js
-rw-r--r-- root/root     24275 2019-12-14 10:11 ./usr/lib/x86_64-linux-gnu/nodejs/ws/lib/websocket.js
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/agent-base/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/agent-base/dist/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/agent-base/dist/src/
-rw-r--r-- root/root      2642 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/agent-base/dist/src/index.d.ts
-rw-r--r-- root/root      7738 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/agent-base/dist/src/index.js
-rw-r--r-- root/root      5455 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/agent-base/dist/src/index.js.map
-rw-r--r-- root/root       299 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/agent-base/dist/src/promisify.d.ts
-rw-r--r-- root/root       495 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/agent-base/dist/src/promisify.js
-rw-r--r-- root/root       499 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/agent-base/dist/src/promisify.js.map
-rw-r--r-- root/root      1501 2019-12-11 06:15 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/agent-base/package.json
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/
-rw-r--r-- root/root       138 2018-12-23 08:49 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/binding.gyp
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/
-rw-r--r-- root/root     12743 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Makefile
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Release/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Release/.deps/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Release/.deps/Release/
-rw-r--r-- root/root       223 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Release/.deps/Release/bufferutil.node.d
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Release/.deps/Release/obj.target/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Release/.deps/Release/obj.target/bufferutil/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Release/.deps/Release/obj.target/bufferutil/src/
-rw-r--r-- root/root      1159 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Release/.deps/Release/obj.target/bufferutil/src/bufferutil.o.d
-rw-r--r-- root/root       256 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Release/.deps/Release/obj.target/bufferutil.node.d
-rw-r--r-- root/root     14424 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Release/bufferutil.node
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Release/obj.target/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Release/obj.target/bufferutil/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Release/obj.target/bufferutil/src/
-rw-r--r-- root/root     25440 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Release/obj.target/bufferutil/src/bufferutil.o
-rw-r--r-- root/root     14424 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/Release/obj.target/bufferutil.node
-rw-r--r-- root/root       118 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/binding.Makefile
-rw-r--r-- root/root      3705 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/bufferutil.target.mk
-rw-r--r-- root/root      2193 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/build/config.gypi
-rw-r--r-- root/root       899 2018-12-23 08:49 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/fallback.js
-rw-r--r-- root/root       136 2018-12-23 08:49 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/index.js
-rw-r--r-- root/root       721 2018-12-23 08:49 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/package.json
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/src/
-rw-r--r-- root/root      3682 2018-12-23 08:49 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/bufferutil/src/bufferutil.c
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/https-proxy-agent/
-rw-r--r-- root/root       545 2019-12-10 22:21 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/https-proxy-agent/index.d.ts
-rw-r--r-- root/root      6325 2019-12-10 22:21 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/https-proxy-agent/index.js
-rw-r--r-- root/root       777 2019-12-10 22:21 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/https-proxy-agent/package.json
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/
-rw-r--r-- root/root       138 2018-12-23 09:01 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/binding.gyp
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/
-rw-r--r-- root/root     12751 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Makefile
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Release/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Release/.deps/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Release/.deps/Release/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Release/.deps/Release/obj.target/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Release/.deps/Release/obj.target/validation/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Release/.deps/Release/obj.target/validation/src/
-rw-r--r-- root/root      1159 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Release/.deps/Release/obj.target/validation/src/validation.o.d
-rw-r--r-- root/root       256 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Release/.deps/Release/obj.target/validation.node.d
-rw-r--r-- root/root       223 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Release/.deps/Release/validation.node.d
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Release/obj.target/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Release/obj.target/validation/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Release/obj.target/validation/src/
-rw-r--r-- root/root     14680 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Release/obj.target/validation/src/validation.o
-rw-r--r-- root/root     14424 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Release/obj.target/validation.node
-rw-r--r-- root/root     14424 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/Release/validation.node
-rw-r--r-- root/root       118 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/binding.Makefile
-rw-r--r-- root/root      2193 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/config.gypi
-rw-r--r-- root/root      3705 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/build/validation.target.mk
-rw-r--r-- root/root      1671 2018-12-23 09:01 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/fallback.js
-rw-r--r-- root/root       136 2018-12-23 09:01 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/index.js
-rw-r--r-- root/root       757 2018-12-23 09:01 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/package.json
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/src/
-rw-r--r-- root/root      2179 2018-12-23 09:01 ./usr/lib/x86_64-linux-gnu/nodejs/ws/node_modules/utf-8-validate/src/validation.c
-rw-r--r-- root/root      1735 2019-12-14 10:11 ./usr/lib/x86_64-linux-gnu/nodejs/ws/package.json
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/wscat/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/lib/x86_64-linux-gnu/nodejs/wscat/bin/
-rwxr-xr-x root/root      9864 2019-11-16 10:26 ./usr/lib/x86_64-linux-gnu/nodejs/wscat/bin/wscat
-rw-r--r-- root/root       556 2019-11-16 10:26 ./usr/lib/x86_64-linux-gnu/nodejs/wscat/package.json
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/share/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/share/doc/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/share/doc/node-ws/
-rw-r--r-- root/root      4487 2019-12-14 10:11 ./usr/share/doc/node-ws/README.md.gz
-rw-r--r-- root/root      1664 2020-01-21 18:56 ./usr/share/doc/node-ws/changelog.Debian.gz
-rw-r--r-- root/root      1985 2020-01-20 16:20 ./usr/share/doc/node-ws/copyright
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/share/doc/node-ws/examples/
drwxr-xr-x root/root         0 2019-12-14 10:11 ./usr/share/doc/node-ws/examples/express-session-parse/
-rw-r--r-- root/root      2101 2019-12-14 10:11 ./usr/share/doc/node-ws/examples/express-session-parse/index.js
-rw-r--r-- root/root       215 2019-12-14 10:11 ./usr/share/doc/node-ws/examples/express-session-parse/package.json
drwxr-xr-x root/root         0 2019-12-14 10:11 ./usr/share/doc/node-ws/examples/express-session-parse/public/
-rw-r--r-- root/root      1743 2019-12-14 10:11 ./usr/share/doc/node-ws/examples/express-session-parse/public/app.js
-rw-r--r-- root/root       721 2019-12-14 10:11 ./usr/share/doc/node-ws/examples/express-session-parse/public/index.html
drwxr-xr-x root/root         0 2019-12-14 10:11 ./usr/share/doc/node-ws/examples/server-stats/
-rw-r--r-- root/root       766 2019-12-14 10:11 ./usr/share/doc/node-ws/examples/server-stats/index.js
-rw-r--r-- root/root       149 2019-12-14 10:11 ./usr/share/doc/node-ws/examples/server-stats/package.json
drwxr-xr-x root/root         0 2019-12-14 10:11 ./usr/share/doc/node-ws/examples/server-stats/public/
-rw-r--r-- root/root      1470 2019-12-14 10:11 ./usr/share/doc/node-ws/examples/server-stats/public/index.html
-rw-r--r-- root/root       969 2019-12-14 10:11 ./usr/share/doc/node-ws/examples/ssl.js
-rw-r--r-- root/root      5294 2019-12-14 10:11 ./usr/share/doc/node-ws/ws.md.gz
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/share/man/
drwxr-xr-x root/root         0 2020-01-21 18:56 ./usr/share/man/man1/
-rw-r--r-- root/root       904 2020-01-21 18:56 ./usr/share/man/man1/wscat.1.gz
lrwxrwxrwx root/root         0 2020-01-21 18:56 ./usr/bin/wscat -> ../lib/x86_64-linux-gnu/nodejs/wscat/bin/wscat



More information about the Pkg-javascript-devel mailing list