[Pkg-javascript-devel] Bug#953646: node-nodedbi: please make the build reproducible

[Chris Lamb]

Source: node-nodedbi
Version: 1.0.13+dfsg-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
node-nodedbi could not be built reproducibly.

This is because it embedded the build path within files under a /.dep/
directory. For example:

   /usr/lib/x86_64-linux-gnu/nodejs/nodedbi/build/Release/.deps/Release/obj.target/nodedbi/src/query.o.d

This is all a little confusing as you exclude .deps (via -X/.deps/) in
debian/rules, but this is not making any difference as the files are
installed via dh_auto_install (not dh_install)... but surely the
Debhelper buildsystem should be excluding these anyway..? You also
attempt to fix some permissions for a directory that can only
exist under .deps due to the wildcard, so when I prevent the .deps
being installed via some ugly means, this line then fails.

Patch attached that, at least, makes it build reproducibly but
moreoever a concrete demonstration of what I mean in the above
rambling paragraphs; you likely do not want to apply it as-is. :)

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: node-nodedbi.diff.txt
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20200311/3d742110/attachment.txt>