[Pkg-javascript-devel] Updating node-magic-string

[Julien Puydt]

Hi,

node-magic-string has a FTBFS bug because the build dep on rollup at
least version 1 isn't satisfiable - that's not the case anymore, so I
decided to give it a go.

It turns out the new upstream version breaks two tests in node-buble
(but not the other depends of node-magic-string - I checked).

Perhaps it's just a question of updating the tests... but I am not
convinced it's the only problem (otherwise a trivial patch will make
tests pass!), so if someone could have a look and confirm, that would
help.

Thanks,

J.Puydt

PS: the end of the failing log is :
  525 passing (5s)
  2 pending
  2 failing

  1) buble
       cli
         creates-inline-sourcemap:

      AssertionError [ERR_ASSERTION]: [ { name: 'output.js',
    contents:
     'var answer = function () { return 42; };\n\n//#
sourceMappingURL=data:application/... deepEqual [ { name: 'output.js',
    contents:
     'var answer = function () { return 42; };\n\n//#
sourceMappingURL=data:application/...
      + expected - actual

       [
         {
      -    "contents": "var answer = function () { return 42; };\n\n//#
sourceMappingURL=data:application/json;charset=utf-
8;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoib3V0cHV0LmpzIiwic291cmNlcyI6WyIuLi
9pbnB1dC5qcyJdLCJzb3VyY2VzQ29udGVudCI6WyJjb25zdCBhbnN3ZXIgPSAoKSA9PiA0M
jtcbiJdLCJuYW1lcyI6WyJjb25zdCJdLCJtYXBwaW5ncyI6IkFBQUFBLEdBQUssQ0FBQyxN
QUFNLFlBQUcsWUFBTSxLQUFFLENBQUM7In0="
      +    "contents": "var answer = function () { return 42; };\n\n//#
sourceMappingURL=data:application/json;charset=utf-
8;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoib3V0cHV0LmpzIiwic291cmNlcyI6WyIuLi
9pbnB1dC5qcyJdLCJzb3VyY2VzQ29udGVudCI6WyJjb25zdCBhbnN3ZXIgPSAoKSA9PiA0M
jtcbiJdLCJuYW1lcyI6WyJjb25zdCJdLCJtYXBwaW5ncyI6IkFBQUFBLEdBQUssQ0FBQyxN
QUFNLFlBQUcsR0FBRyxTQUFHLEtBQUUsQ0FBQzsifQ=="
           "name": "output.js"
         }
       ]
      
      at child_process.exec (test/test.js:119:15)
      at ChildProcess.exithandler (child_process.js:285:7)
      at maybeClose (internal/child_process.js:982:16)
      at Process.ChildProcess._handle.onexit
(internal/child_process.js:259:5)

  2) buble
       cli
         creates-sourcemap:

      AssertionError [ERR_ASSERTION]: [ { name: 'output.js',
    contents:
     'var answer = function () { return 42; };\n\n//#
sourceMappingURL=output.js.map' },... deepEqual [ { name: 'output.js',
    contents:
     'var answer = function () { return 42; };\n\n//#
sourceMappingURL=output.js.map' },...
      + expected - actual

         }
         {
           "contents": {
             "file": "output.js"
      -      "mappings": "AAAAA,GAAK,CAAC,MAAM,YAAG,YAAM,KAAE,CAAC;"
      +      "mappings":
"AAAAA,GAAK,CAAC,MAAM,YAAG,GAAG,SAAG,KAAE,CAAC;"
             "names": [
               "const"
             ]
             "sources": [
      
      at child_process.exec (test/test.js:119:15)
      at ChildProcess.exithandler (child_process.js:285:7)
      at maybeClose (internal/child_process.js:982:16)
      at Process.ChildProcess._handle.onexit
(internal/child_process.js:259:5)