[Pkg-javascript-devel] [RFS] node-jsonld

[Jonas Smedegaard]

Quoting Xavier (2020-03-18 21:34:36)
> Le 18/03/2020 à 21:30, Jonas a écrit :
> > Quoting Xavier (2020-03-17 19:54:01)
> >> Le 17/03/2020 à 19:22, Jonas Smedegaard a écrit :
> >>> Quoting Nilesh Patra (2020-02-02 18:51:01)
> >>>> On Sun, 2 Feb 2020 at 22:48, Jonas Smedegaard <jonas at jones.dk>
> > wrote:
> >>>>
> >>>>> Quoting Nilesh Patra (2020-02-02 16:01:57)
> >>>>>> I fixed node-jsonld to build with Node.js >= 12. It builds fine in
> >>>>>> a clean chroot, and autopkgtests pass.
> >>> [...]
> >>>>> I reduced your module resolving patch to only add /usr/share/nodejs
> >>>>> - if the two relative paths ('.' and 'node_modules') are really
> >>>>> needed then please explain why (again, I may very well have missed
> >>>>> something, but it looks to me like a dirty hack which might cause
> >>>>> trouble at least on non-clean build environments).
> >>>>>
> >>>>
> >>>> I have faced issues with webpack failing to resolve modules when they
> >>>> are embedded.
> >>>> I added that in to avoid webpack failing to recognize those, if in
> >>>> case modules are embedded in future.
> >>>
> >>> I have now identified that webpack.config.js needs the following:
> >>>
> >>> +    resolve: {
> >>> +      modules:
> > ['/usr/lib/nodejs','/usr/share/nodejs','/usr/share/nodejs/babel-runtime/node_modules'],
> >>> +    },
> >>> +    resolveLoader: {
> >>> +      modules: ['/usr/lib/nodejs','/usr/share/nodejs'],
> >>> +    },
> >>>
> >>> To me that smells of an error in node-babel-runtime.
> >>
> >> Hi,
> >>
> >> I fixed something that looks like this in @babel/runtime 7.4.5:
> >>
> > https://salsa.debian.org/js-team/node-babel/-/blob/babel7/debian/patches/load-plugins-from-system-libraries.diff
> > 
> > Please consider fixing it for babel 6 and release to unstable.
> 
> node-babel 6 seems to use standard nodejs paths to search its plugins

It seems you are replying to my message, but I don't recognize how it 
relates to what I wrote.

Does you message imply "thanks for the suggestion, now considered but 
rejected because..." or "thanks, I agree and..." or something else?


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20200318/60cf4e99/attachment.sig>