[Pkg-javascript-devel] Bug#959798: Bug#959798: libjs-webrtc-adapter ftbfs with node-grunt-babel 8.0 (using babel 7.4) in experimental

[Pirate Praveen]

On Thu, May 14, 2020 at 1:12 pm, Jonas Smedegaard <jonas at jones.dk> 
wrote:
> retitle -1 libjs-webrtc-adapter: Build with babel version 7
> tags -1 +help -patch
> 
> Quoting Pirate Praveen (2020-05-05 15:11:31)
>>  I'm planning to upload node-grunt-babel 8.0 in unstable (it is in
>>  experimental currently). I have fixed all the reverse build
>>  dependencies and this is the only remaining blocker. I have fixed 
>> this
>>  package in babel7 branch of salsa.
> 
> I doubt the patch was actually tested - I was unable to reproduce a
> succesful build.
> 

It built fine for me, attaching sbuild log.

> I have now simplified the package to use node-babel-cli directly, so
> that the failure can be examined more directly.
> 
> It seems the issue is that Babel 6 compiles subdirectories into
> subdirectories, whereas Babel 7 compiles everything _flatly_ into
> --out-dir.
> 
> Help solving this is much appreciated.

This patch fixes the build,

diff --git a/debian/control b/debian/control
index f4bcaae4..27320b90 100644
--- a/debian/control
+++ b/debian/control
@@ -7,8 +7,7 @@ Uploaders:
 Build-Depends:
  brotli,
  debhelper-compat (= 12),
- node-babel-cli,
- node-babel-preset-env,
+ node-babel7,
  node-browserify-lite,
  node-rtcpeerconnection-shim,
  node-sdp,
diff --git a/debian/rules b/debian/rules
index 0cb988ba..66b2fad5 100755
--- a/debian/rules
+++ b/debian/rules
@@ -27,8 +27,7 @@ override_dh_auto_build: $(patsubst 
%,debian/js/%.min.js.gz,$(STEMS))

 # build browser libraries
 dist/adapter_core5.js: src/js/adapter_core5.js
-       cd src/js && babeljs --no-babelrc --presets=env --out-dir 
../../dist \
-               -- '*.js' '**/*.js'
+       babeljs --no-babelrc --presets=@babel/env src/js -d dist
 dist_x/adapter_core5.js: dist/adapter_core5.js
        cp --force --archive dist dist_x
        rm dist_x/edge/edge_shim.js


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: libjs-webrtc-adapter_7.5.1~ds-1_amd64-2020-05-14T12:14:42Z.build
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20200514/dc8dbbd8/attachment.ksh>