[Pkg-javascript-devel] Bug#961791: Bug#961791: node-jsesc: please increase autopkgtest timeouts

[Jonas Smedegaard]

Quoting Gianfranco Costamagna (2020-05-29 12:22:38)
> Source: node-jsesc
> Version: 3.0.1-1
> tags: patch
> 
> Hello, on some slow arm machines, mocha tests are timeouting on 20seconds timeout.
> 
> Can you please increase it a little bit?
> 
> 
> diff -Nru node-jsesc-3.0.1/debian/tests/upstreamtestsuite node-jsesc-3.0.1/debian/tests/upstreamtestsuite
> --- node-jsesc-3.0.1/debian/tests/upstreamtestsuite     2020-04-12 08:45:28.000000000 +0200
> +++ node-jsesc-3.0.1/debian/tests/upstreamtestsuite     2020-05-29 10:33:42.000000000 +0200
> @@ -2,4 +2,4 @@
>  set -e
>  
>  sed tests/tests.js -e "s|'../jsesc.js'|'jsesc'|g" > tests.js
> -mocha tests.js
> +mocha tests.js --timeout 40000

Please do not play timing games - *disable* timeout instead (unless for 
tests strictly about timing - e.g. security testing about avoiding 
timing attacks).


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20200529/9a801c4e/attachment.sig>