[Pkg-javascript-devel] Bug#972570: Bug#972570: node-lightgallery is built using minified files

[Jonas Smedegaard]

Quoting Yadd (2021-04-23 17:47:23)
> Control: tags -1 + pending
> 
> Le 23/04/2021 à 09:44, Daniel Ring a écrit :
> > Hello Xavier,
> > 
> > It looks like the build process was minifying the source files to the
> > destination *.js files and copying the pre-minified files to *.min.js. I
> > corrected it to copy the unminified files directly and minify them to
> > *.min.js.
> > 
> > I also updated the package on Salsa to exclude the minified
> > modules/*.min.js files via Files-Excluded in d/copyright, so they're no
> > longer in the source package at all.
> > 
> > Sincerely,
> > Daniel Ring
> 
> Hi,
> 
> looks good to me, thanks! Could you also ignore these warnings in a
> debain/lintian-overrides? It looks like false positive
> 
> Cheers,
> Yadd
> 
>  W: node-lightgallery: privacy-breach-generic
> usr/share/nodejs/lightgallery/dist/js/lg-video.min.min.js [<iframe
> class="lg-video-object lg-dailymotion '+o+'" '+l+' width="560"
> height="315"
> src="//www.dailymotion.com/embed/video/'+t.dailymotion[1]+d+'"
> frameborder="0" allowfullscreen>]
> (//www.dailymotion.com/embed/video/'+t.dailymotion[1]+d+')
> W: node-lightgallery: privacy-breach-generic
> usr/share/nodejs/lightgallery/dist/js/lg-video.min.min.js [<iframe
> class="lg-video-object lg-vimeo '+o+'" '+l+' width="560" height="315"
> src="//player.vimeo.com/video/'+t.vimeo[1]+d+'" frameborder="0"
> webkitallowfullscreen mozallowfullscreen allowfullscreen>]
> (//player.vimeo.com/video/'+t.vimeo[1]+d+')
> W: node-lightgallery: privacy-breach-generic
> usr/share/nodejs/lightgallery/dist/js/lg-video.min.min.js [<iframe
> class="lg-video-object lg-vk '+o+'" '+l+' width="560" height="315"
> src="//vk.com/video_ext.php?'+t.vk[1]+d+'" frameborder="0"
> allowfullscreen>] (//vk.com/video_ext.php?'+t.vk[1]+d+')
> W: node-lightgallery: privacy-breach-generic
> usr/share/nodejs/lightgallery/dist/js/lg-video.min.min.js [<iframe
> class="lg-video-object lg-youtube '+o+'" '+l+' width="560" height="315"
> src="//www.youtube.com/embed/'+t.youtube[1]+d+'" frameborder="0"
> allowfullscreen>] (//www.youtube.com/embed/'+t.youtube[1]+d+')

Those warnings look real to me.

What makes you consider them false positives, Xavier?

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20210423/6dd36beb/attachment.sig>