[Pkg-javascript-devel] [RFS] -- node-vue-hot-reload-api

[Nilesh Patra]

On 4/28/21 6:13 PM, ajayi Olatunji wrote:
>
> Hi there,
>
> I have updated the node module node-vue-hot-reload-api from version
> 2.3.1 to 2.3.4. The package is available at
> https://salsa.debian.org/thegodtune/node-vue-hot-reload-apiand I am
> requesting for sponsorship, thanks.
>
> This time, I have ensured to check and correct all necessary lintian
> and sbuild compatibility issues.
>
* It seems that you did not gbp-import properly, rather merged since the
hashes of this[1] and this[2] are different and [1] contains change to a
changelog entry which it should not. You probably committed the change
instead of importing and merging. Fix this, please.

* Your changelog does not contain account of the things you changed
(adding dh-sequence-nodejs, enabling tests, compat bump, standards
version et. al.) - consider add this.

[1]:
https://salsa.debian.org/thegodtune/node-vue-hot-reload-api/-/commit/dc21f47622e5882f7b72f96a97dfa9ce361e1d48
[2]:
https://salsa.debian.org/thegodtune/node-vue-hot-reload-api/-/commit/43c42b748eb010f19bb4088cf38e8635c5d468dd

Nilesh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20210428/0b9b1bec/attachment.htm>