[Pkg-javascript-devel] node-strip-json-comments: a dirty patch

[Yadd]

Le 26/08/2021 à 06:25, Julien Puydt a écrit :
> Hi,
> 
> I updated the node-strip-json-comments package ; it required refreshing
> the existing patch (porting upstream test suite to a framework we
> have), which was pretty normal, but also, and I find it annnoying, a
> new one.
> 
> The upstream package.json declares it's a JS module, so it can't be
> require'd. Yes, that meant autopkgtest-pkg-nodejs' most basic test was
> failing! And I figured that also meant every dep in Debian would fail
> likewise.
> 
> So the new patch:
> https://salsa.debian.org/js-team/node-strip-json-comments/-/blob/master/debian/patches/dont_be_a_module.patch
> reverts upstream's change, so hopefully everything keeps on working.
> 
> But still, I find it dirty, and when we'll have both deps which require
> and deps which import, we'll probably have a problem.
> 
> Can someone more knowledgeable chime in and make nice
> observations/propositions?

Hi,

use `echo require > debian/tests/pkg-js/SKIP` for such modules.

Cheers,
Yadd