[Pkg-javascript-devel] node-strip-json-comments: a dirty patch

[Pirate Praveen]

2021, ഓഗസ്റ്റ് 27 6:47:50 PM IST, Julien Puydt <julien.puydt at gmail.com>ൽ എഴുതി
>Le vendredi 27 août 2021 à 12:20 +0200, Yadd a écrit :
>> use `echo require > debian/tests/pkg-js/SKIP` for such modules.
>
>That makes a node-something package not try to require itself as part
>of the autopkgtest-ing ; but I don't think that answers my question.
>
>The current upstream version of strip-json-comments declares it's a JS-
>module -- hence it can't be require'd. With my dirty patch, I made it
>possible again, so existing node-* packages work -- that was the goal:
>don't break deps.
>
>But of course, future packages (or future versions of existing ones)
>will probably work différently. Let's assume in the near future we end
>up with:
>(1) node-foo wants to import node-strip-json-comments ;
>(2) node-bar wants to require it.
>If I understand well, without my dirty patch, node-bar has a problem,
>and with it node-foo has a problem.
>
>So my question is: is it possible to handle things cleanly and how?
>
>[If not, I'll drop the patch and upload a breaking package immediately:
>the sooner broken, the sooner fixed...]

Please use experimental for breaking changes. Upload to unstable only after fixing all reverse dependencies or giving a reasonable notice with a important severity bug.

This is like a major version transition. All dependencies may also need updates to use import instead of require.

May be pkg-js-tools should skip require tests for modules which declare type=module in package.json
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.