[Pkg-javascript-devel] On node-svgo

[Yadd]

On 10/12/2021 09:27, Julien Puydt wrote:
> Hi,
> 
> Le jeudi 09 décembre 2021 à 17:16 +0100, Jonas Smedegaard a écrit :
>> Quoting Julien Puydt (2021-12-09 17:05:57)
>>> Hi,
>>>
>>> on salsa we have a node-svgo, and the changelog shows traces of
>>> having
>>> been uploaded to unstable ; but I don't find the package in NEW and
>>> can't install it.
>>>
>>> What's amusing is that if you have a look at "npm2deb svgo", you'll
>>> see
>>> there is no Debian package, but "npm2deb depends svgo" will still
>>> say:
>>>
>>> Warnings occurred:
>>>   [warning] csso: csso is included in node-svgo. Package it
>>> separately
>>> and remove it from node-svgo if you need it for another module.
>>>   [warning] stable: stable is included in node-svgo. Package it
>>> separately and remove it from node-svgo if you need it for another
>>> module.
>>>   [warning] prettier: Useless in Debian compilation, see node-jest
>>> for
>>> an example
>>>
>>> Finally, there's an ITP bug: https://bugs.debian.org/887376 -- and
>>> it
>>> doesn't look like it was ever closed.
>>>
>>> What is the status of this?
>>
>> The odd warning likely comes from here:
>> https://wiki.debian.org/Javascript/Nodejs/Database
>>
>> Perhaps the package simply has not yet entered Debian¹ at all?
>>
>>   - Jonas
>>
>> ¹ Salsa is not Debian - it is a playground for creating Debian.
>>
> 
> I know salsa is a playground, but I had mixed signals, so I was lost.
> 
> I reworked the package a little - refraining from updating to a more
> recent upstream, because it looked like more work. That means quite a
> few patches to cope with new api in other packages, but I made
> autopkgtest run so I'm pretty confident about those.
> 
> I'm still annoyed with:
> E: node-svgo source: source-is-missing
> debian/node_modules/csso/dist/csso-browser.js
> which I don't really know how I want to fix, but I think it looks
> pretty good.

Hi,

I think you can safely drop this file: csso-browser.js isn't used by svgo.
But having unupdated modules in debian/node_modules that are installed 
isn't a good practive. We should use uscan components for this.

Cheers,
Yadd